Add storing of invalid ROC number error (errorType=36) in pixel GPU code

[ferencek]

PR description:

This is the latest in the series of PRs addressing imbalance in pixel FED errors in the GPU and CPU codes. After #42977 or, to be more precise, its 13_2_X backport #42978 was deployed in HI data taking, a remaining tiny mismatch concerning errorType=36 (invalid ROC number) was observed in online DQM for run 375202. The origin of this mismatch was traced to the this CPU code block handling errorType=36 that does not have its equivalent in the GPU code. This missing piece in the GPU is added in this PR.

PR validation:

To test the PR a single event where an error of type 36 occurs was picked from /HIExpressPhysics/HIRun2023A-Express-v2/FEVT (Run 375202, Event 158786571, LumiSection 177) and a modified version of wf 141.008583 was run on it. Before this PR the DQM plot the SiPixelHeterogeneous/PixelErrorCompareGPUvsCPU/FEErrorVsFEDIdUnbalance shows a mismatch

and with the PR applied the mismatch is gone

This errors is fairly rare and it required processing close to 250k events from run 375202 in /HIExpressPhysics/HIRun2023A-Express-v2/FEVT to find the first occurrence of this error.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport to 13_2_X planned.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43052/37253

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): [DO NOT MERGE] remove duplicate pixels #37359

[cmsbuild]

A new Pull Request was created by @ferencek (Dinko F.) for master.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@VourMa, @mtosi, @JanFSchulte, @gpetruc, @tvami, @rovere, @GiacomoSguazzoni, @felicepantaleo, @mroguljic, @missirol, @dkotlins, @mmusich, @ferencek, @VinInn, @threus this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[mmusich]

enable gpu

[mmusich]

please test

[cmsbuild]

-1

Failed Tests: RelVals-GPU
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a215df/35264/summary.html
COMMIT: 638bf9f
CMSSW: CMSSW_13_3_X_2023-10-18-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43052/35264/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-GPU

• 12434.58712434.587_TTbar_14TeV+2023_Patatrack_AllTripletsGPU_Validation/step2_TTbar_14TeV+2023_Patatrack_AllTripletsGPU_Validation.log

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 1064
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356314
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a215df/35337/summary.html
COMMIT: 638bf9f
CMSSW: CMSSW_13_3_X_2023-10-22-0000/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43052/35337/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 7 lines from the logs
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3357369
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 21
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 39719
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1