[13_2_X] Additional fix for pixel FED error imbalance in DQM plots

[ferencek]

PR description:

Backport of #42977

[cmsbuild]

A new Pull Request was created by @ferencek (Dinko F.) for CMSSW_13_2_X.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks.
@dkotlins, @GiacomoSguazzoni, @gpetruc, @ferencek, @rovere, @threus, @mroguljic, @mmusich, @VinInn, @JanFSchulte, @felicepantaleo, @missirol, @VourMa, @mtosi, @tvami this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Additional fix for pixel FED error imbalance in DQM plots #42977

[cmsbuild]

Pull request #42978 was updated. @jfernan2, @mandrenguyen, @cmsbuild can you please check and sign again.

[mmusich]

test parameters:

• enable = gpu
• workflows_gpu = 11634.503, 11634.507, 11634.583, 11634.587, 11634.593
• relvals_opt_gpu = --what upgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano
• addpkg = DQM/Integration

[mmusich]

please test

[mmusich]

urgent

• I am flagging this, because it would be great to have online to validate the (hopefully perfect at this point) closure of CPU vs GPU unpacking of pixel FED errors, and proceed to close Large GPU/CPU difference in soft electron reconstruction related to pixel unpacker #41715 if that turn out positive

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06ab87/35120/summary.html
COMMIT: a6f722c
CMSSW: CMSSW_13_2_X_2023-10-10-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42978/35120/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3198423
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3198398
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 80 differences found in the comparisons
• DQMHistoTests: Total files compared: 8
• DQMHistoTests: Total histograms compared: 228951
• DQMHistoTests: Total failures: 2599
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 226352
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 7 files compared)
• Checked 28 log files, 35 edm output root files, 8 DQM output files
• TriggerResults: no differences found

[antoniovilela]

ping @cms-sw/reconstruction-l2

[mandrenguyen]

backport of #42977

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1

[gparida]

Hi everyone, These are studies to check the impact of this PR on CPU-GPU differences.
For this, the reference and target area are as follows:

1. reference: CMSSW_13_2_5_patch3, /dev/CMSSW_13_2_0/GRun/V68
2. target: reference + cms-sw/cmssw#42978

With respect to the reference, there is a reduction in the discrepancy upon including cms-sw/cmssw#42978.
For example
Reference:

Total	Reference CPU	Reference GPU	Gained	Lost	Change	Percentage Change	trigger

1583141	43	57	14	0	14	32.56	HLT_AK8PFJet250_SoftDropMass40_PNetTauTau0p05_v3

1583141	133	152	21	-2	23	17.29	HLT_PFHT800_PFMET75_PFMHT75_IDTight_v18

Target:

1568131	41	44	3	0	3	7.32	HLT_AK8PFJet250_SoftDropMass40_PNetTauTau0p05_v3

1568131	133	138	6	-1	7	5.26	HLT_PFHT800_PFMET75_PFMHT75_IDTight_v18

Details can be found in this spreadsheet