-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCAL: fix applyQIEdelay() for MC timing studies #43072
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43072/37296
|
A new Pull Request was created by @abdoulline (Salavat Abdullin) for master. It involves the following packages:
@cmsbuild, @mdhildreth, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd38de/35319/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Enables both positive and negative time shifts of the signal at the end of DIGI step.
NB: fixed code is not used by default in any wfs.
Can be used only with an appropriate customization for timing alignment tests/studies.
PR validation:
Compiles, private tests confirmed expected results.