Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestGeneratorInterfacePythia8ConcurrentGeneratorFilter: follow redirects #43089

Merged
merged 1 commit into from
Oct 24, 2023
Merged

TestGeneratorInterfacePythia8ConcurrentGeneratorFilter: follow redirects #43089

merged 1 commit into from
Oct 24, 2023

Conversation

iarspider
Copy link
Contributor

PR description:

Test TestGeneratorInterfacePythia8ConcurrentGeneratorFilter is failing with the following error:

===== Test "TestGeneratorInterfacePythia8ConcurrentGeneratorFilter" ====
+ cmsDriver.py GIP8/BTV-RunIISummer20UL17GEN-00002-fragment.py --python_filename test_BTV-RunIISummer20UL17GEN-00002_1_cfg.py --eventcontent RAWSIM --customise Configuration/DataProcessing/Utils.addMonitoring --datatier GEN --fileout file:test_BTV-RunIISummer20UL17GEN-00002.root --conditions auto:run2_mc --beamspot Realistic25ns13TeVEarly2017Collision --customise_commands 'process.source.numberEventsInLuminosityBlock=cms.untracked.uint32(10)' --step GEN --geometry DB:Extended --era Run2_2017 --no_exec --mc -n 50 --nThreads 4 --nConcurrentLumis 0
GEN,ENDJOB
with DB:
Step: GEN Spec: 
Loading generator fragment from GIP8.BTV-RunIISummer20UL17GEN-00002-fragment
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/sw/ppc64le/week0/el8_ppc64le_gcc12/cms/cmssw/CMSSW_13_3_X_2023-10-22-2300/src/Configuration/Applications/python/ConfigBuilder.py", line 1430, in prepare_GEN
    __import__(loadFragment)
  File "/scratch/cmsbuild/jenkins_b/workspace/ib-run-qa/CMSSW_13_3_X_2023-10-22-2300/unit_tests/TestGeneratorInterfacePythia8ConcurrentGeneratorFilter/GIP8/BTV-RunIISummer20UL17GEN-00002-fragment.py", line 1
    <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
    ^
SyntaxError: invalid syntax

This is due to original URL now returning a redirect message. This PR adds -L flag to cURL invocation to let it follow redirects.

PR validation:

Bot tests

@iarspider
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Oct 23, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43089/37322

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • GeneratorInterface/Pythia8Interface (generators)

@mkirsano, @bbilin, @GurpreetSinghChahal, @SiewYan, @menglu21, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@iarspider iarspider mentioned this pull request Oct 23, 2023
Merged
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ecaa9/35357/summary.html
COMMIT: b8ceef4
CMSSW: CMSSW_13_3_X_2023-10-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43089/35357/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ecaa9/35357/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ecaa9/35357/git-merge-result

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 30 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 1070
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356308
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@makortel makortel mentioned this pull request Oct 23, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Oct 24, 2023
Merged
@perrotta
Copy link
Contributor

type bug

This was referenced Oct 24, 2023
Closed
Merged
@menglu21
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2238f0c into cms-sw:master Oct 24, 2023
This was referenced Oct 25, 2023
Merged
Merged
This was referenced Nov 4, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@iarspider iarspider deleted the patch-11 branch February 27, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix code-checks-approved fully-signed generators-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_3_X
Development

Successfully merging this pull request may close these issues.
5 participants
@iarspider @cmsbuild @perrotta @menglu21 @rappoccio