Fix may be used uninitialized warning in `RecoTracker/MeasurementDet` (el8_aarch64_gcc12) #43034

aandvalenzuela · 2023-10-17T08:34:19Z

Hello,

I followed @makortel suggestion on #42625 (comment) to fix the following warning in el8_aarch64_gcc12 IBs (I think the same reasoning applies here):

  /data/cmsbld/jenkins_b/workspace/build-any-ib/w/tmp/BUILDROOT/dcf6cec92d4b7e97e1c4b72c2e293d08/opt/cmssw/el8_aarch64_gcc12/cms/cmssw/CMSSW_13_3_X_2023-10-15-2300/src/RecoTracker/MeasurementDet/plugins/TkPixelMeasurementDet.h:17:18: warning: 'MEM[(const struct TkPixelMeasurementDet &)&D.27209].id_' may be used uninitialized [-Wmaybe-uninitialized]
    17 | class dso_hidden TkPixelMeasurementDet final : public MeasurementDet {
      |                  ^
/data/cmsbld/jenkins_b/workspace/build-any-ib/w/tmp/BUILDROOT/dcf6cec92d4b7e97e1c4b72c2e293d08/opt/cmssw/el8_aarch64_gcc12/cms/cmssw/CMSSW_13_3_X_2023-10-15-2300/src/RecoTracker/MeasurementDet/plugins/MeasurementTrackerImpl.cc: In member function 'addDets':
/data/cmsbld/jenkins_b/workspace/build-any-ib/w/tmp/BUILDROOT/dcf6cec92d4b7e97e1c4b72c2e293d08/opt/cmssw/el8_aarch64_gcc12/cms/cmssw/CMSSW_13_3_X_2023-10-15-2300/src/RecoTracker/MeasurementDet/plugins/MeasurementTrackerImpl.cc:276:72: note: '<anonymous>' declared here
  276 |     thePixelDets.push_back(TkPixelMeasurementDet(gd, thePxDetConditions));
      |                                                                        ^
In member function '__ct ',
    inlined from 'construct' at /data/cmsbld/jenkins_b/workspace/build-any-ib/w/el8_aarch64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/new_allocator.h:175:4,
    inlined from 'construct' at /data/cmsbld/jenkins_b/workspace/build-any-ib/w/el8_aarch64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/alloc_traits.h:516:17,
    inlined from '_M_realloc_insert' at /data/cmsbld/jenkins_b/workspace/build-any-ib/w/el8_aarch64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/vector.tcc:462:28,
    inlined from 'emplace_back' at /data/cmsbld/jenkins_b/workspace/build-any-ib/w/el8_aarch64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/vector.tcc:123:21,
    inlined from 'push_back' at /data/cmsbld/jenkins_b/workspace/build-any-ib/w/el8_aarch64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_vector.h:1294:21,
    inlined from 'addPixelDet' at /data/cmsbld/jenkins_b/workspace/build-any-ib/w/tmp/BUILDROOT/dcf6cec92d4b7e97e1c4b72c2e293d08/opt/cmssw/el8_aarch64_gcc12/cms/cmssw/CMSSW_13_3_X_2023-10-15-2300/src/RecoTracker/MeasurementDet/plugins/MeasurementTrackerImpl.cc:276:27,
    inlined from 'addDets' at /data/cmsbld/jenkins_b/workspace/build-any-ib/w/tmp/BUILDROOT/dcf6cec92d4b7e97e1c4b72c2e293d08/opt/cmssw/el8_aarch64_gcc12/cms/cmssw/CMSSW_13_3_X_2023-10-15-2300/src/RecoTracker/MeasurementDet/plugins/MeasurementTrackerImpl.cc:232:22:
  /data/cmsbld/jenkins_b/workspace/build-any-ib/w/tmp/BUILDROOT/dcf6cec92d4b7e97e1c4b72c2e293d08/opt/cmssw/el8_aarch64_gcc12/cms/cmssw/CMSSW_13_3_X_2023-10-15-2300/src/RecoTracker/MeasurementDet/plugins/TkPixelMeasurementDet.h:17:18: warning: 'MEM[(const struct TkPixelMeasurementDet &)&D.27209].index_' may be used uninitialized [-Wmaybe-uninitialized]
    17 | class dso_hidden TkPixelMeasurementDet final : public MeasurementDet {
      |                  ^
/data/cmsbld/jenkins_b/workspace/build-any-ib/w/tmp/BUILDROOT/dcf6cec92d4b7e97e1c4b72c2e293d08/opt/cmssw/el8_aarch64_gcc12/cms/cmssw/CMSSW_13_3_X_2023-10-15-2300/src/RecoTracker/MeasurementDet/plugins/MeasurementTrackerImpl.cc: In member function 'addDets':
/data/cmsbld/jenkins_b/workspace/build-any-ib/w/tmp/BUILDROOT/dcf6cec92d4b7e97e1c4b72c2e293d08/opt/cmssw/el8_aarch64_gcc12/cms/cmssw/CMSSW_13_3_X_2023-10-15-2300/src/RecoTracker/MeasurementDet/plugins/MeasurementTrackerImpl.cc:276:72: note: '<anonymous>' declared here
  276 |     thePixelDets.push_back(TkPixelMeasurementDet(gd, thePxDetConditions));
      |                                                                        ^
Leaving library rule at src/RecoTracker/MeasurementDet/plugins

See full log at CMSSW_13_3_X_2023-10-16-2300.

Tested with a local build.

aandvalenzuela · 2023-10-17T08:39:10Z

please test for el8_aarch64_gcc12

cmsbuild · 2023-10-17T08:42:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43034/37211

This PR adds an extra 20KB to repository

cmsbuild · 2023-10-17T08:43:06Z

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for master.

It involves the following packages:

RecoTracker/MeasurementDet (reconstruction)

@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@missirol, @GiacomoSguazzoni, @rovere, @ebrondol, @gpetruc, @VourMa, @JanFSchulte, @felicepantaleo, @mtosi, @VinInn, @mmusich, @dgulhan this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

aandvalenzuela · 2023-10-17T08:53:10Z

please test for el8_aarch64_gcc12

cmsbuild · 2023-10-17T08:53:15Z

@aandvalenzuela, CMSSW_13_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

smuzaffar · 2023-10-17T09:46:36Z

please test for CMSSW_13_3_X/el8_aarch64_gcc12

smuzaffar · 2023-10-17T10:02:03Z

@aandvalenzuela , there were duplicate entries for el8_aarch64_gcc12 in cms-bot/config.map that is why bot failed. This is fixed now and tests are running now

aandvalenzuela · 2023-10-17T10:08:02Z

Thanks!

cmsbuild · 2023-10-17T12:54:21Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34ccc4/35218/summary.html
COMMIT: 0243e41
CMSSW: CMSSW_13_3_X_2023-10-16-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43034/35218/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

1000.0

----- Begin Fatal Exception 17-Oct-2023 14:15:31 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root?tried=+1213xrootd-cms-redir-int.cr.cnaf.infn.it,&xrdcl.requuid=21954c2e-d8ca-4344-aa60-cb93dde18ccf
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

312.0

----- Begin Fatal Exception 17-Oct-2023 14:17:41 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_12_5_1/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/125X_mcRun3_2022_realistic_HI_v5-v1/2580000/70fa6078-d491-4627-8d79-350da062bbf2.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_12_5_1/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/125X_mcRun3_2022_realistic_HI_v5-v1/2580000/70fa6078-d491-4627-8d79-350da062bbf2.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_12_5_1/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/125X_mcRun3_2022_realistic_HI_v5-v1/2580000/70fa6078-d491-4627-8d79-350da062bbf2.root
      [c] Input file root://xrootd-cms.infn.it//store/relval/CMSSW_12_5_1/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/125X_mcRun3_2022_realistic_HI_v5-v1/2580000/70fa6078-d491-4627-8d79-350da062bbf2.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_12_5_1/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/125X_mcRun3_2022_realistic_HI_v5-v1/2580000/70fa6078-d491-4627-8d79-350da062bbf2.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_12_5_1/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/125X_mcRun3_2022_realistic_HI_v5-v1/2580000/70fa6078-d491-4627-8d79-350da062bbf2.root?tried=+1213llrxrd-redir.in2p3.fr,&xrdcl.requuid=dcd7b250-3371-49e0-bbb7-90b57cfdc7be
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

10224.0

----- Begin Fatal Exception 17-Oct-2023 14:17:55 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_12_0_0_pre4/RelValMinBias_13/GEN-SIM/113X_mc2017_realistic_v5-v1/00000/10b42b56-9e4e-408e-98c2-f378b07201db.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_12_0_0_pre4/RelValMinBias_13/GEN-SIM/113X_mc2017_realistic_v5-v1/00000/10b42b56-9e4e-408e-98c2-f378b07201db.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_12_0_0_pre4/RelValMinBias_13/GEN-SIM/113X_mc2017_realistic_v5-v1/00000/10b42b56-9e4e-408e-98c2-f378b07201db.root
      [c] Input file root://xrootd-cms.infn.it//store/relval/CMSSW_12_0_0_pre4/RelValMinBias_13/GEN-SIM/113X_mc2017_realistic_v5-v1/00000/10b42b56-9e4e-408e-98c2-f378b07201db.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_12_0_0_pre4/RelValMinBias_13/GEN-SIM/113X_mc2017_realistic_v5-v1/00000/10b42b56-9e4e-408e-98c2-f378b07201db.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_12_0_0_pre4/RelValMinBias_13/GEN-SIM/113X_mc2017_realistic_v5-v1/00000/10b42b56-9e4e-408e-98c2-f378b07201db.root?tried=+1213xrootd-redic.pi.infn.it,&xrdcl.requuid=5ff6f5e6-7c56-4b1d-aca9-86bb0c3059c8
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

25202.0

aandvalenzuela · 2023-10-17T14:32:26Z

please test for CMSSW_13_3_X/el8_aarch64_gcc12

cmsbuild · 2023-10-23T11:33:05Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34ccc4/35342/summary.html
COMMIT: 0243e41
CMSSW: CMSSW_13_3_X_2023-10-22-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43034/35342/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestGeneratorInterfacePythia8ConcurrentGeneratorFilter had ERRORS

cmsbuild · 2023-10-23T14:55:30Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34ccc4/35350/summary.html
COMMIT: 0243e41
CMSSW: CMSSW_13_3_X_2023-10-22-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43034/35350/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test testPromptPPSAlCaRecoProducer had ERRORS
---> test TestGeneratorInterfacePythia8ConcurrentGeneratorFilter had ERRORS

iarspider · 2023-10-23T16:03:13Z

Test failures are unrelated to this PR:

testPromptPPSAlCaRecoProducer -> [ARM] XML DOM Exception in Calibration/PPSAlCaRecoProducer/testPromptPPSAlCaRecoProducer #42581
TestGeneratorInterfacePythia8ConcurrentGeneratorFilter -> TestGeneratorInterfacePythia8ConcurrentGeneratorFilter: follow redirects #43089

aandvalenzuela · 2023-11-02T08:30:14Z

please test for CMSSW_13_3_X/el8_aarch64_gcc12

Just to update the tests, the warning is still present

cmsbuild · 2023-11-02T11:18:09Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34ccc4/35555/summary.html
COMMIT: 0243e41
CMSSW: CMSSW_13_3_X_2023-11-01-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43034/35555/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testPromptPPSAlCaRecoProducer had ERRORS

aandvalenzuela · 2023-11-02T16:04:18Z

As mentioned in #43034 (comment), the error in test testPromptPPSAlCaRecoProducer is unrelated.

Gentle ping to @cms-sw/reconstruction-l2. Can we merge this small fix?

mandrenguyen · 2023-11-02T17:15:31Z

+1

cmsbuild · 2023-11-02T17:15:55Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-11-03T20:53:56Z

+1

rappoccio · 2023-11-03T21:07:20Z

merge

Failures are unrelated.

Fix may be used uninitialized

0243e41

cmsbuild added this to the CMSSW_13_3_X milestone Oct 17, 2023

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Oct 17, 2023

cmsbuild added tests-started and removed tests-pending labels Oct 17, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 17, 2023

cmsbuild added tests-pending and removed tests-started labels Oct 17, 2023

aandvalenzuela changed the base branch from master to CMSSW_13_3_X October 17, 2023 08:52

cmsbuild changed the base branch from CMSSW_13_3_X to master October 17, 2023 08:53

cmsbuild added tests-started and removed tests-pending labels Oct 17, 2023

cmsbuild added tests-rejected and removed tests-started labels Oct 17, 2023

cmsbuild added tests-started and removed tests-rejected labels Oct 23, 2023

cmsbuild added tests-rejected tests-started and removed tests-started tests-rejected labels Oct 23, 2023

cmsbuild added tests-rejected and removed tests-started labels Oct 23, 2023

cmsbuild added tests-started and removed tests-rejected labels Nov 2, 2023

cmsbuild added tests-rejected and removed tests-started labels Nov 2, 2023

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Nov 2, 2023

cmsbuild added orp-approved and removed orp-pending labels Nov 3, 2023

cmsbuild merged commit 21c20dd into cms-sw:master Nov 3, 2023
9 of 10 checks passed

cmsbuild mentioned this pull request Nov 4, 2023

Add new SimBeamSpotHLLHC CondFormat #43186

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix may be used uninitialized warning in `RecoTracker/MeasurementDet` (el8_aarch64_gcc12) #43034

Fix may be used uninitialized warning in `RecoTracker/MeasurementDet` (el8_aarch64_gcc12) #43034

aandvalenzuela commented Oct 17, 2023

aandvalenzuela commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

aandvalenzuela commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

smuzaffar commented Oct 17, 2023

smuzaffar commented Oct 17, 2023

aandvalenzuela commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

aandvalenzuela commented Oct 17, 2023

cmsbuild commented Oct 23, 2023

cmsbuild commented Oct 23, 2023

iarspider commented Oct 23, 2023

aandvalenzuela commented Nov 2, 2023

cmsbuild commented Nov 2, 2023

aandvalenzuela commented Nov 2, 2023

mandrenguyen commented Nov 2, 2023

cmsbuild commented Nov 2, 2023

rappoccio commented Nov 3, 2023

rappoccio commented Nov 3, 2023

Fix may be used uninitialized warning in RecoTracker/MeasurementDet (el8_aarch64_gcc12) #43034

Fix may be used uninitialized warning in RecoTracker/MeasurementDet (el8_aarch64_gcc12) #43034

Conversation

aandvalenzuela commented Oct 17, 2023

aandvalenzuela commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

aandvalenzuela commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

smuzaffar commented Oct 17, 2023

smuzaffar commented Oct 17, 2023

aandvalenzuela commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

RelVals

aandvalenzuela commented Oct 17, 2023

cmsbuild commented Oct 23, 2023

Unit Tests

cmsbuild commented Oct 23, 2023

Unit Tests

iarspider commented Oct 23, 2023

aandvalenzuela commented Nov 2, 2023

cmsbuild commented Nov 2, 2023

Unit Tests

aandvalenzuela commented Nov 2, 2023

mandrenguyen commented Nov 2, 2023

cmsbuild commented Nov 2, 2023

rappoccio commented Nov 3, 2023

rappoccio commented Nov 3, 2023

Fix may be used uninitialized warning in `RecoTracker/MeasurementDet` (el8_aarch64_gcc12) #43034

Fix may be used uninitialized warning in `RecoTracker/MeasurementDet` (el8_aarch64_gcc12) #43034