-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of printf()-like formatting to MessageLogger #30629
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30629/16897
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
b28d903
to
58a3ab1
Compare
The code-checks are being triggered in jenkins. |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30629/16898
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: FWCore/MessageLogger @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
MessageLogger has always used the formatting encouraged by C++ standard. The future standard is encouraging |
That doesn't mean that people shouldn't be given the freedom to use the formatting they are more comfortable with - see all the uses of |
-1 Tested at: 58a3ab1 CMSSW: CMSSW_11_2_X_2020-07-09-2300 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test TestFWCoreServicesDriver had ERRORS |
closing this PR now. Please open a new one if needed. |
PR description:
Following the discussion in #30463 this PR implements
printf
-style formatting for the MessageLogger objects.The syntax is, for example:
edm::LogInfo(category).printf(format, ...)
.The implementation reuses the
{fmt}
library introduced in #30626.PR validation:
Unit tests run and pass.