-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move edm::ErrorSummaryEntry to DataFormats/Common #32706
Conversation
Splitting them in hopes of making it easier to do ROOT modules.
All edm::ErrorSummaryEntry member are in DataFormats/Common.
@davidlange6 FYI |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32706/20825
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DPGAnalysis/Skims @perrotta, @smuzaffar, @andrius-k, @Dr15Jones, @jordan-martins, @chayanit, @wajidalikhan, @fwyzard, @ErnestaP, @Martin-Grunewald, @makortel, @cmsbuild, @jfernan2, @kmaeshima, @fioriNTU, @slava77, @jpata, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used:
See details on the summary page. |
why do we still need |
[in case the question got lost over the weekend] |
I want to keep FWCore/MessageLogger to be not dependent upon DataFormats/Common since MessageLogger is a 'low level' framework component. So edm::messagelogger::* are the objects MessageLogger uses. The edm::* ones are those which have dictionaries and can be stored. |
+1
|
hi @Dr15Jones - did you consider a new DataFormats package instead of DataFormats/Common that keeps only the specific things needed by FWCOre/MessageLogger? FWCore/MessageLogger already depends on DataFormats/Provenance so it would not be a big change from today's situation. |
+1 |
unassign analysis |
@cms-sw/pdmv-l2 do you have any comments? |
Pull request #32706 was updated. @chayanit, @wajidalikhan, @santocch, @jordan-martins can you please check and sign again. |
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). |
PR description:
Keep edm::ErrorSummaryEntry for storage into the Event and create a new edm::messagelogger::ErrorSummaryEntry as part of MessageLogger. This will hopefully make it easier to migrate to ROOT's module system as we can avoid generating a dictionary for FWCore/MessageLogger.
PR validation:
The code compiles.