Add support of printf()-like formatting to MessageLogger

[fwyzard]

PR description:

Implement printf-style formatting for the MessageLogger objects.
The syntax is, for example: edm::LogInfo(category).printf(format, ...).

PR validation:

Unit tests should run and pass.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37245/28844

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/MessageService/bin/Standalone.cpp modified in PR(s): Fix typos in MessageLogger tests #37244
  • File FWCore/MessageService/test/UnitTestClient_C.cc modified in PR(s): Fix typos in MessageLogger tests #37244
  • File FWCore/MessageService/test/UnitTestClient_G.cc modified in PR(s): Fix typos in MessageLogger tests #37244
  • File FWCore/MessageService/test/unit_test_outputs/infos.log modified in PR(s): Fix typos in MessageLogger tests #37244
  • File FWCore/MessageService/test/unit_test_outputs/u10_warnings.log modified in PR(s): Fix typos in MessageLogger tests #37244
  • File FWCore/MessageService/test/unit_test_outputs/u20_cerr.log modified in PR(s): Fix typos in MessageLogger tests #37244
  • File FWCore/MessageService/test/unit_test_outputs/u6_warnings.log modified in PR(s): Fix typos in MessageLogger tests #37244
  • File FWCore/MessageService/test/unit_test_outputs/warnings.log modified in PR(s): Fix typos in MessageLogger tests #37244

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• FWCore/MessageLogger (core)
• FWCore/MessageService (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adb0b4/23126/summary.html
COMMIT: 75eae20
CMSSW: CMSSW_12_4_X_2022-03-14-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37245/23126/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @bsunanda Run3-gex119C Take care of compilation warnings in Validation/RecoMET #37232

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adb0b4/23126/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adb0b4/23126/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_edmPickEvents had ERRORS
---> test materialBudgetTrackerPlots had ERRORS

Comparison Summary

The workflows 1001.0, 1000.0, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695377
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695347
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adb0b4/35634/summary.html
COMMIT: 75eae20
CMSSW: CMSSW_13_3_X_2023-11-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37245/35634/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adb0b4/35634/git-merge-result

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

[smuzaffar]

ping

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[antoniovilela]

ping (to make bot change milestone)

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.