Increase field width in MessageLogger Summary #46241
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46241/42060 |
|
A new Pull Request was created by @tomalin for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
-1 Failed Tests: UnitTests Unit TestsI found 14 errors in the following unit tests: ---> test unitTestsGroup_2_u9 had ERRORS ---> test unitTestsGroup_3_u17 had ERRORS ---> test unitTestsGroup_4_u20 had ERRORS and more ... Comparison SummarySummary:
|
|
I'm intrigued that the DQMHistoTests reports failures for this PR, given that it doesn't change any code that could affect a histogram. (Unless the checks are parsing the MessageLogger Summary and histogramming the results?). |
|
The comparison differences are known non-reproducibilities (mainly #39803, and the ones related to MessageLogger are just things being reordered or something) |
|
The failing unit tests would, however, need to be fixed by updating the reference logs. |
| "---------------- ----- -----\n"; | ||
| s << " type category sev module " | ||
| " subroutine count total\n" | ||
| << " ---- -------------------- -- --------------------- " |
There was a problem hiding this comment.
I think this printout would need 4 more - and spaces for the "module" column, because the width was increased by 9 from 16 to 21.
There was a problem hiding this comment.
True. Sorry that was careless of me. Now fixed.
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-rejected
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46241/42103 |
|
Pull request #46241 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again. |
|
Pull request #46241 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again. |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test test_SiStripG2GainsValidator had ERRORS Comparison SummarySummary:
|
|
I see the UnitTests are still failing in test_SiStripG2GainsValidator . If I run scram b runtests on my computer, this specific test crashes with exit status 58 whilst executing the command: /usr/bin/curl -k -L --user-agent "MyUserAgent" --cert /net/home/ppd/tomalin/.globus/usercert.pem --key /net/home/ppd/tomalin/.globus/userkey.pem --connect-timeout 30 --retry 3 https://cmsweb.cern.ch/t0wmadatasvc/prod/firstconditionsaferun If I run the command stand-alone, it works, but demands my GRID certificate password. This crash doesn't seem the same that is reported by the tests for this PR in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c49a8b/42273/unitTests/src/CondCore/SiStripPlugins/test/test_SiStripG2GainsValidator/testing.log . Not sure what else I can do. |
nothing. That failed in IBs as well, but got fixed in #46414. |
|
Comparison differences are related to #46416 |
|
+core |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
@cmsbuild, ignore tests-rejected with with ib-failure |
|
Thanks @tomalin for working it through! |
|
@cmsbuild, ignore tests-rejected with ib-failure |
|
+1 |
PR description:
In the "MessageLogger Summary" at the end of a CMSSW job, particularly if one sets the MessageLogger printout level to INFO, so messages for many modules are printed out, one sees that strings corresponding to the names of the "modules" and "subroutines" are often so heavily truncated that it's not possible to identify them.
This PR increases the width of the "module" field from 16 to 25 letters and of the "subroutine" field from 16 to 21 letters. Although this doesn't eliminate truncation, it reduces it enough that most of the modules can be identified in the summary. The PR also adjusts the columns heading positions of the MessageLogger Summary to match the increased field widths.
This is a small code change, but will obviously affect many CMSSW jobs.