-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LogFwk* logging levels to be used by the framework #31815
Conversation
The new options use the level fwkInfo which lies between info and warning.
-This required updating many test results
The code-checks are being triggered in jenkins. |
NOTE: I decided to wait for another pull request to actually use the new threshold as many non-framework configurations are dependent upon how the default MessageLogger config is structured right now. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31815/19117
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
-1 Tested at: 09216a8 CMSSW: CMSSW_11_2_X_2020-10-15-1100 I found follow errors while testing this PR Failed tests: Build HeaderConsistency
I found compilation error when building: >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/src/TtHadEvtSolution.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/src/TtGenEvent.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/src/TtSemiLepEvtPartons.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/src/TtSemiEvtSolution.cc In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/src/TtEvent.cc:3: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/FWCore/MessageLogger/interface/MessageLogger.h:124:42: error: conflicting declaration 'using LogInfo = class edm::Log' using LogInfo = Log; ^ In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/src/TtEvent.cc:1: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/interface/TtEvent.h:24:9: note: previous declaration as 'class edm::LogInfo' class LogInfo; |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
Needed to remove forward declaration of edm::LogInfo since that is no longer a class. The function did not depend on anything in the class anyway.
Comparison is ready Comparison Summary:
|
+1 |
+1 |
@cms-sw/upgrade-l2 it would be great if you could sign this |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This should make it easier to set a theshold such that INFO messages are ignored but the framework status messages are still kept.
PR validation:
Code compiles and framework unit tests pass.