Look for a way to reject non-framework INFO messages earlier

[makortel]

This issue is motivated by #31757. The default MessageLogger configuration sets the message threshold to INFO

cmssw/FWCore/MessageService/python/MessageLogger_cfi.py

Line 48 in 260347d

threshold = cms.untracked.string('INFO')

(likely) because the FwkReport and FwkSummary messages are INFO

cmssw/FWCore/Framework/src/InputSource.cc

Lines 339 to 344 in 260347d

	if (isInfoEnabled()) {
	LogVerbatim("FwkReport") << "Begin processing the " << readCount_ << suffix(readCount_) << " record. Run "
	<< eventID.run() << ", Event " << eventID.event() << ", LumiSection "
	<< eventID.luminosityBlock() << " on stream " << streamID.value() << " at "
	<< std::setprecision(3) << TimeOfDay();
	}

cmssw/FWCore/Framework/src/Schedule.cc

Line 942 in 260347d

LogVerbatim("FwkSummary") << "";

The default limit of INFO messages is set to 0

cmssw/FWCore/MessageService/python/MessageLogger_cfi.py

Lines 23 to 25 in 260347d

	INFO = cms.untracked.PSet(
	limit = cms.untracked.int32(0)
	),

A downside of this approach (as demonstrated by #31757) is that MessageLogger gets many INFO messages that get filtered out later. We should look for a way to reject the INFO messages earlier, but still keep the FwkReport and FwkSummary printed out by default.

[makortel]

assign core

[cmsbuild]

New categories assigned: core

@Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Issue was created by @makortel Matti Kortelainen.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

(based on a chat with @Dr15Jones)

A general approach would be to use the message categories to reject the other than FwkReport and FwkSummary messages early (the necessary information is in the configuration). On other other hand, doing a "contains" check on a "set of strings" on every LogInfo call sounds potentially expensive.

A faster alternative could be to introduce a "FWK Info" message level between WARNING and INFO (reserving it purely for framework usage; either "hacking" it internally, or making it visible outside framework as well). This approach would allow to

• keep the current behavior of being able suppress FwkReport and FwkSummary messages by setting the default threshold to WARNING
• reject non-framework INFO messages early on (with callback style call also the string formatting would be skipped)

[makortel]

This was implemented in #31815

[makortel]

+1

[cmsbuild]

This issue is fully signed and ready to be closed.