delete unused headers #31870

davidlange6 · 2020-10-20T08:42:36Z

As raised in #31505

none of these files are used in any way (well some are used by others that themselves are unused) - unused means not used in any compilation unit or test.

cmsbuild · 2020-10-20T08:43:19Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-20T08:49:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31870/19239

This PR adds an extra 220KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File TrackingTools/Records/interface/Records.h modified in PR(s): Track classifier using TensorFlow #31682

cmsbuild · 2020-10-20T08:50:27Z

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

Alignment/LaserAlignment
Alignment/MuonAlignmentAlgorithms
CalibCalorimetry/EcalLaserAnalyzer
CalibCalorimetry/HcalAlgos
CalibFormats/SiPixelObjects
CalibMuon/CSCCalibration
Calibration/IsolatedParticles
Calibration/Tools
CommonTools/CandAlgos
CommonTools/CandUtils
CommonTools/ParticleFlow
CommonTools/Statistics
CommonTools/UtilAlgos
CommonTools/Utils
CondCore/DTPlugins
CondFormats/CastorObjects
CondFormats/Common
CondFormats/DataRecord
CondFormats/HcalObjects
CondFormats/Serialization
CondFormats/SiPixelObjects
CondTools/Ecal
CondTools/L1Trigger
CondTools/RPC
CondTools/SiStrip
DataFormats/BTauReco
DataFormats/Common
DataFormats/GeometrySurface
DataFormats/GeometryVector
DataFormats/METReco
DataFormats/Math
DataFormats/ParticleFlowReco
DataFormats/Provenance
DataFormats/RPCDigi
DataFormats/SiPixelDigi
DataFormats/SiStripCluster
DataFormats/SiStripCommon
DataFormats/SiStripDigi
DataFormats/TrackerRecHit2D
DataFormats/TrajectorySeed
ElectroWeakAnalysis/WENu
ElectroWeakAnalysis/ZEE
ElectroWeakAnalysis/ZMuMu
EventFilter/DTRawToDigi
EventFilter/ESRawToDigi
EventFilter/EcalRawToDigi
EventFilter/RPCRawToDigi
EventFilter/Utilities
FWCore/ServiceRegistry
GeneratorInterface/TauolaInterface
HeavyFlavorAnalysis/SpecificDecay
IOPool/Common
JetMETCorrections/InterpolationTables
JetMETCorrections/Type1MET
L1Trigger/DTSectorCollector
L1Trigger/GlobalCaloTrigger
L1Trigger/L1TCalorimeter
L1Trigger/L1TMuonOverlap
L1Trigger/L1TNtuples
L1TriggerOffline/L1Analyzer
MagneticField/Engine
MagneticField/VolumeGeometry
Mixing/Base
OnlineDB/CSCCondDB
OnlineDB/EcalCondDB
PhysicsTools/FWLite
PhysicsTools/MVAComputer
PhysicsTools/PatExamples
PhysicsTools/PatUtils
PhysicsTools/SelectorUtils
PhysicsTools/UtilAlgos
PhysicsTools/Utilities
RecoEcal/EgammaClusterProducers
RecoEgamma/EgammaTools
RecoHI/HiJetAlgos
RecoJets/JetAnalyzers
RecoLocalCalo/EcalRecAlgos
RecoMuon/TrackingTools
RecoTracker/SpecialSeedGenerators
RecoTracker/TkMSParametrization
RecoTracker/TrackProducer
RecoTracker/TransientTrackingRecHit
RecoVertex/ConfigurableVertexReco
RecoVertex/KinematicFit
RecoVertex/LinearizationPointFinders
SimCalorimetry/CaloSimAlgos
SimDataFormats/RPCDigiSimLink
SimDataFormats/TrackerDigiSimLink
SimG4CMS/Calo
SimG4Core/Application
SimG4Core/Notification
TopQuarkAnalysis/TopTools
TrackingTools/AnalyticalJacobians
TrackingTools/GsfTools
TrackingTools/PatternTools
TrackingTools/Records

@SiewYan, @ggovi, @christopheralanwest, @rekovic, @tlampen, @alberto-sanchez, @pohsun, @santocch, @perrotta, @civanch, @yuanchao, @makortel, @cmsbuild, @agrohsje, @GurpreetSinghChahal, @smorovic, @smuzaffar, @Dr15Jones, @mdhildreth, @tocheng, @slava77, @jpata, @benkrikler, @mkirsano, @emeschi can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @gouskos, @erikbutz, @yslai, @felicepantaleo, @slomeo, @hatakeyamak, @robervalwalsh, @emilbols, @apsallid, @argiro, @Martin-Grunewald, @mschrode, @jazzitup, @thomreis, @alberto-sanchez, @lgray, @abbiendi, @ebrondol, @seemasharmafnal, @pakhotin, @mmarionncern, @kreczko, @JyothsnaKomaragiri, @makortel, @smoortga, @afiqaize, @JanFSchulte, @jhgoh, @dgulhan, @jdolen, @mandrenguyen, @yenjie, @cericeci, @fwyzard, @ptcox, @ferencek, @dkotlins, @pieterdavid, @jainshilpi, @yetkinyilmaz, @mtosi, @Sam-Harper, @kurtejung, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @tocheng, @threus, @schoef, @alesaggio, @mmusich, @abdoulline, @fabiocos, @clelange, @mkirsano, @namapane, @calderona, @HuguesBrun, @adewit, @rchatter, @trocino, @riga, @battibass, @varuns23, @Fedespring, @wddgit, @ahinzmann, @sobhatta, @lecriste, @cbernet, @gpetruc, @mariadalfonso, @rociovilar, @andrzejnovak, @folguera, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2020-10-20T08:53:20Z

please test

cmsbuild · 2020-10-20T08:53:55Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-19-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10119/console Started: 2020/10/20 10:56

cmsbuild · 2020-10-20T11:20:49Z

-1

Tested at: 023deee

CMSSW: CMSSW_11_2_X_2020-10-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Removed unused fwkJobReports from MessageLogger in Geometry Subsystem #31858 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in Geometry Subsystem
Added LogFwk* logging levels to be used by the framework #31815 @Dr15Jones: Added LogFwk* logging levels to be used by the framework
Sub-event aware genJet and parton matching for HI miniAOD #31698 @mandrenguyen: Sub-event aware genJet and parton matching for HI miniAOD
Add anti-electron tauID for phase2 #31470 @cms-tau-pog: Add anti-electron tauID for phase2
Add maximum of pileup pT hats in JME custom NanoAOD #31831 @nurfikri89: Add maximum of pileup pT hats in JME custom NanoAOD
Removed unused fwkJobReports from MessageLogger in SLHCUpgradeSimulations Subsystem #31861 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in SLHCUpgradeSimulations Subsystem
Removed unused fwkJobReports from MessageLogger in IOMC Subsystem #31860 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in IOMC Subsystem

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02bef3/10119/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02bef3/10119/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02bef3/10119/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found compilation error when building:

Entering library rule at DataFormats/GeometryVector
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-19-2300/src/DataFormats/GeometryVector/src/TrackingJacobians.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-19-2300/src/DataFormats/GeometryVector/src/print.cc
>> Building LCG reflex dict from header file src/DataFormats/GeometryVector/src/classes.h
In file included from input_line_9:60:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-19-2300/src/DataFormats/GeometryVector/interface/Basic3DVector.h:11:10: fatal error: 'private/oldBasic3DVector.h' file not found
#include "private/oldBasic3DVector.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: rootcling: compilation failure (tmp/slc7_amd64_gcc820/src/DataFormats/GeometryVector/src/DataFormatsGeometryVector/a/DataFormatsGeometryVector_xr66f8e3389a_dictUmbrella.h)
gmake: *** [tmp/slc7_amd64_gcc820/src/DataFormats/GeometryVector/src/DataFormatsGeometryVector/a/DataFormatsGeometryVector_xr.cc] Error 1
>> Compiling LCG dictionary: tmp/slc7_amd64_gcc820/src/DataFormats/GeometryVector/src/DataFormatsGeometryVector/a/DataFormatsGeometryVector_xr.cc

Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

In file included from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-19-2300/src/TrackingTools/TrajectoryParametrization/interface/LocalTrajectoryParameters.h:1:
In file included from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-19-2300/src/DataFormats/TrajectoryState/interface/LocalTrajectoryParameters.h:4:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-19-2300/src/DataFormats/GeometryVector/interface/LocalPoint.h:5:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-19-2300/src/DataFormats/GeometryVector/interface/Point2DBase.h:5:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-19-2300/src/DataFormats/GeometryVector/interface/PV2DBase.h:4:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-19-2300/src/DataFormats/GeometryVector/interface/Basic2DVector.h:10:10: fatal error: 'private/oldBasic2DVector.h' file not found
#include "private/oldBasic2DVector.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
#0 0x00002ac2a5c30b8f PrintStackTraceSignalHandler(void*) (/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-19-2300/external/slc7_amd64_gcc820/lib/libCling.so+0x268cb8f)
#1 0x00002ac2a5c2e8fe llvm::sys::RunSignalHandlers() (/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-19-2300/external/slc7_amd64_gcc820/lib/libCling.so+0x268a8fe)
#2 0x00002ac2a5c2eb36 SignalHandler(int) (/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-19-2300/external/slc7_amd64_gcc820/lib/libCling.so+0x268ab36)

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Removed unused fwkJobReports from MessageLogger in Geometry Subsystem #31858 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in Geometry Subsystem
Added LogFwk* logging levels to be used by the framework #31815 @Dr15Jones: Added LogFwk* logging levels to be used by the framework
Sub-event aware genJet and parton matching for HI miniAOD #31698 @mandrenguyen: Sub-event aware genJet and parton matching for HI miniAOD
Add anti-electron tauID for phase2 #31470 @cms-tau-pog: Add anti-electron tauID for phase2
Add maximum of pileup pT hats in JME custom NanoAOD #31831 @nurfikri89: Add maximum of pileup pT hats in JME custom NanoAOD
Removed unused fwkJobReports from MessageLogger in SLHCUpgradeSimulations Subsystem #31861 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in SLHCUpgradeSimulations Subsystem
Removed unused fwkJobReports from MessageLogger in IOMC Subsystem #31860 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in IOMC Subsystem

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02bef3/10119/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02bef3/10119/git-merge-result

cmsbuild · 2020-10-20T11:20:51Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

slava77 · 2020-10-22T14:11:46Z

@davidlange6
for the reco files, I think that in some cases some triage is needed, to OK the removal or not, rather than blindly having all removed.
Please break this PR in pieces so that non-reco subsystems are done separately.
Thank you.

agrohsje · 2020-10-23T13:41:50Z

+1

slava77 · 2020-10-29T17:01:21Z

@davidlange6
for the reco files, I think that in some cases some triage is needed, to OK the removal or not, rather than blindly having all removed.
Please break this PR in pieces so that non-reco subsystems are done separately.
Thank you.

slava77 · 2020-11-05T14:29:24Z

@davidlange6
for the reco files, I think that in some cases some triage is needed, to OK the removal or not, rather than blindly having all removed.
Please break this PR in pieces so that non-reco subsystems are done separately.
Thank you.

slava77 · 2020-11-12T14:46:54Z

@davidlange6
for the reco files, I think that in some cases some triage is needed, to OK the removal or not, rather than blindly having all removed.
Please break this PR in pieces so that non-reco subsystems are done separately.
Thank you.

slava77 · 2020-11-23T15:12:24Z

@davidlange6
for the reco files, I think that in some cases some triage is needed, to OK the removal or not, rather than blindly having all removed.
Please break this PR in pieces so that non-reco subsystems are done separately.
Thank you.

IIRC, from the ORP last week we can expect a split here.
what is the status of this?
@davidlange6 please clarify.
Thank you.

slava77 · 2020-11-30T13:35:08Z

@davidlange6
for the reco files, I think that in some cases some triage is needed, to OK the removal or not, rather than blindly having all removed.
Please break this PR in pieces so that non-reco subsystems are done separately.
Thank you.

IIRC, from the ORP last week we can expect a split here.
what is the status of this?
@davidlange6 please clarify.
Thank you.

slava77 · 2020-12-14T15:28:01Z

IIRC, from the ORP a few weeks ago we can expect a split here.
what is the status of this?
@davidlange6 please clarify.
Thank you.

slava77 · 2021-01-04T14:44:56Z

@davidlange6
please clarify on the status of this PR.
Thank you.

slava77 · 2021-01-14T14:42:03Z

-1

an update is necessary anyways to pass the tests

silviodonato · 2021-02-17T16:37:49Z

Feel free to use "Ready to review" as soon as there are news

delete unused headers

023deee

davidlange6 mentioned this pull request Oct 20, 2020

(A subset of) unused (header) files in cmssw #31505

Open

cmsbuild added this to the CMSSW_11_2_X milestone Oct 20, 2020

cmsbuild added alca-pending analysis-pending code-checks-pending comparison-pending core-pending daq-pending db-pending generators-pending l1-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending labels Oct 20, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 20, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 20, 2020

cmsbuild removed comparison-pending tests-started labels Oct 20, 2020

cmsbuild added comparison-notrun tests-rejected labels Oct 20, 2020

cmsbuild added generators-approved and removed generators-pending labels Oct 23, 2020

cmsbuild mentioned this pull request Oct 28, 2020

Clean BuildFiles in OnlineDB/CSCCondDB #31912

Merged

cmsbuild mentioned this pull request Nov 12, 2020

Track classifier using TensorFlow - continuation #32128

Merged

smuzaffar modified the milestones: CMSSW_11_2_X, CMSSW_11_3_X Nov 26, 2020

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels Jan 14, 2021

cmsbuild mentioned this pull request Feb 15, 2021

Cleaning of several Analysis packages #32917

Merged

silviodonato marked this pull request as draft February 17, 2021 16:37

davidlange6 closed this Mar 15, 2021

ggovi mentioned this pull request Aug 18, 2021

Delete unused headers/test files (DB packages) #34933

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

delete unused headers #31870

delete unused headers #31870

davidlange6 commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

smuzaffar commented Oct 20, 2020

cmsbuild commented Oct 20, 2020 •

edited

Loading

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

slava77 commented Oct 22, 2020

agrohsje commented Oct 23, 2020

slava77 commented Oct 29, 2020

slava77 commented Nov 5, 2020

slava77 commented Nov 12, 2020

slava77 commented Nov 23, 2020

slava77 commented Nov 30, 2020

slava77 commented Dec 14, 2020

slava77 commented Jan 4, 2021

slava77 commented Jan 14, 2021

silviodonato commented Feb 17, 2021

delete unused headers #31870

delete unused headers #31870

Conversation

davidlange6 commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

smuzaffar commented Oct 20, 2020

cmsbuild commented Oct 20, 2020 • edited Loading

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

slava77 commented Oct 22, 2020

agrohsje commented Oct 23, 2020

slava77 commented Oct 29, 2020

slava77 commented Nov 5, 2020

slava77 commented Nov 12, 2020

slava77 commented Nov 23, 2020

slava77 commented Nov 30, 2020

slava77 commented Dec 14, 2020

slava77 commented Jan 4, 2021

slava77 commented Jan 14, 2021

silviodonato commented Feb 17, 2021

cmsbuild commented Oct 20, 2020 •

edited

Loading