-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove edm::ELstring #31530
Remove edm::ELstring #31530
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31530/18506
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: FWCore/MessageLogger @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
@Dr15Jones Please review |
The tests are being triggered in jenkins.
|
-1 Tested at: ca50699 CMSSW: CMSSW_11_2_X_2020-09-21-2300 I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-21-2300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Tue Sep 22 10:07:08 2020-date Tue Sep 22 10:04:57 2020 s - exit: 21504 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@cmsbuild, please test Failures looked like transient I/O errors, let's try again |
The tests are being triggered in jenkins.
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31530/18545
|
Pull request #31530 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@Dr15Jones Do you have any further comments? |
No further comments |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Replace its use with
std::string
orstd::string_view
. Following a suggestion #31498 (comment).PR validation:
Framework unit tests pass.