Clean up BuildFiles under CalibTracker/ #29651

fwyzard · 2020-05-05T11:52:10Z

Clean up BuildFile.xml filea with xmllint --format.

fwyzard · 2020-05-05T11:52:11Z

@cmsbuild, please test

cmsbuild · 2020-05-05T11:52:36Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-05T11:57:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29651/15049

This PR adds an extra 28KB to repository

cmsbuild · 2020-05-05T11:57:46Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6018/console Started: 2020/05/05 13:59

cmsbuild · 2020-05-05T11:57:47Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

CalibTracker/Records
CalibTracker/SiPixelConnectivity
CalibTracker/SiPixelESProducers
CalibTracker/SiPixelErrorEstimation
CalibTracker/SiPixelGainCalibration
CalibTracker/SiPixelIsAliveCalibration
CalibTracker/SiPixelLorentzAngle
CalibTracker/SiPixelQuality
CalibTracker/SiPixelSCurveCalibration
CalibTracker/SiPixelTools
CalibTracker/SiStripAPVAnalysis
CalibTracker/SiStripChannelGain
CalibTracker/SiStripCommon
CalibTracker/SiStripDCS
CalibTracker/SiStripESProducers
CalibTracker/SiStripHitEfficiency
CalibTracker/SiStripLorentzAngle
CalibTracker/SiStripQuality
CalibTracker/StandaloneTrackerTopology

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @argiro, @mverzett, @dkotlins, @alesaggio, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-05-05T15:03:44Z

+1
Tested at: dcf2087
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a361b9/6018/summary.html
CMSSW: CMSSW_11_1_X_2020-05-04-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Add time support to IPCutPFCandidateSelector #29596 @dntaylor: Add time support to IPCutPFCandidateSelector
Clean buildfiles in DQM #29579 @guitargeek: Clean buildfiles in DQM
[LLVM10] L1Trigger and L1TriggerConfig fix clang warnings #29587 @mrodozov: [LLVM10] L1Trigger and L1TriggerConfig fix clang warnings
[LLVM10] PhysicsTools fix clang warnings #29581 @mrodozov: [LLVM10] PhysicsTools fix clang warnings
[LLVM10] OnlineDB fix clang warnings #29583 @mrodozov: [LLVM10] OnlineDB fix clang warnings
added missing dependency; header cleanup #29613 @smuzaffar: added missing dependency; header cleanup
Run3-sim69 Add a few cfi files which defines transition energies for standard G4 versions #29625 @bsunanda: Run3-sim69 Add a few cfi files which defines transition energies for standard G4 versions
ElectronNHitSeedProducer modernization #29512 @guitargeek: ElectronNHitSeedProducer modernization

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a361b9/6018/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a361b9/6018/git-merge-result

cmsbuild · 2020-05-05T15:03:47Z

Comparison job queued.

Clean up BuildFile.xml filea with `xmllint --format`.

cmsbuild · 2020-05-05T16:12:55Z

The code-checks are being triggered in jenkins.

fwyzard · 2020-05-05T16:13:50Z

@cmsbuild, please test

cmsbuild · 2020-05-05T16:17:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29651/15152

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CalibTracker/SiPixelESProducers/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File CalibTracker/SiPixelESProducers/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

cmsbuild · 2020-05-05T16:17:46Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6117/console Started: 2020/05/05 22:29

cmsbuild · 2020-05-05T16:17:47Z

Pull request #29651 was updated. @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please check and sign again.

cmsbuild · 2020-05-05T16:32:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a361b9/6018/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696239
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2695919
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild · 2020-05-05T23:21:45Z

+1
Tested at: d94b90d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a361b9/6117/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Clean up BuildFiles under HLTriggerOffline/ #29637 @fwyzard: Clean up BuildFiles under HLTriggerOffline/
Added particle flow candidates to particle flow validation #29628 @chosila: Added particle flow candidates to particle flow validation

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a361b9/6117/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a361b9/6117/git-merge-result

cmsbuild · 2020-05-05T23:21:48Z

Comparison job queued.

cmsbuild · 2020-05-06T07:37:46Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a361b9/6117/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696239
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2695919
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
Checked 147 log files, 16 edm output root files, 34 DQM output files

silviodonato · 2020-05-06T12:54:18Z

merge

cmsbuild added this to the CMSSW_11_1_X milestone May 5, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels May 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2020

cmsbuild added tests-started and removed tests-pending labels May 5, 2020

cmsbuild added tests-approved and removed tests-started labels May 5, 2020

Clean up BuildFiles under CalibTracker/

d94b90d

Clean up BuildFile.xml filea with `xmllint --format`.

fwyzard force-pushed the branch_lintBuildFile_CalibTracker branch from dcf2087 to d94b90d Compare May 5, 2020 16:12

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels May 5, 2020

cmsbuild removed the code-checks-pending label May 5, 2020

cmsbuild added the code-checks-approved label May 5, 2020

cmsbuild added tests-started and removed tests-pending labels May 5, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 5, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels May 5, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 6, 2020

cmsbuild added orp-approved and removed orp-pending labels May 6, 2020

cmsbuild merged commit dbfd6b1 into cms-sw:master May 6, 2020

cmsbuild mentioned this pull request May 6, 2020

Revert "PUPPI MET in RECO" #29748

Merged

fwyzard deleted the branch_lintBuildFile_CalibTracker branch May 8, 2020 09:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up BuildFiles under CalibTracker/ #29651

Clean up BuildFiles under CalibTracker/ #29651

fwyzard commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020 •

edited

Loading

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020 •

edited

Loading

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 6, 2020

silviodonato commented May 6, 2020

Clean up BuildFiles under CalibTracker/ #29651

Clean up BuildFiles under CalibTracker/ #29651

Conversation

fwyzard commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020 • edited Loading

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020 • edited Loading

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 6, 2020

silviodonato commented May 6, 2020

cmsbuild commented May 5, 2020 •

edited

Loading

cmsbuild commented May 5, 2020 •

edited

Loading