-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ElectronNHitSeedProducer modernization #29512
ElectronNHitSeedProducer modernization #29512
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29512/14762
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: HLTrigger/Configuration @perrotta, @cmsbuild, @fwyzard, @Martin-Grunewald, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 Tested at: 8c71f7d CMSSW: CMSSW_11_1_X_2020-04-17-1100 I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021.log12434.0 step2 runTheMatrix-results/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023.log
I found errors in the following addon tests: cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-04-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2018.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Sat Apr 18 00:46:06 2020-date Sat Apr 18 00:33:29 2020 s - exit: 16640 |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
-1 |
Thanks for the explanations and instructions, I was just about to ask! |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In #29304 it was discussed that the
ElectronSeedProducer
should be replaced at some point with theElectronNHitSeedProducer
which is already used at HLT. That's indeed a good idea, but it would be good if we update theElectronNHitSeedProducer
first to fulfil some good practices for producer plugins, which this PR implements:EDPutToken
ESGetToken
instead of caching the event setup objects manually (the framework does this efficiently for us)stream
toglobal
module to enforce good design practice (likeconst
functions and immutable algorithm classes)In particular, the move to a
global
module was achieved by splitting theTrajSeedMatcher
class up in aconst
configuration structure which is initialized in the constructor of the plugin, and an actual algorithm class which is instantiated for each event using a reference to the configuration. This pattern is already used in some other plugins (like theGsfElectronAlgo
) and I think it makes sense.PR validation:
CMSSW compiles and local matrix tests pass.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.