Continue work on electron seeding convergence

[guitargeek]

PR description:

After #29512, this is the next PR that takes little steps towards the convergence of the HLT and offline electron pixel matching code:

1. Simplify helper structs of TrajSeedMatcher
2. Be more consistent in treating electrons and positrons symmetrically in the offline ElectronSeedProucer, as already started with Remove unused SeedFilter class in EgammaElectronAlgos to simplify ElectronSeedProducer #29304
3. Again fix the hit skipping logic in TrajSeedMatcher. One fix was already done in the previous PR, but I noticed there was still a problem that would end the matching loop prematurely if hits were skipped. After this PR, the logic for hit skipping should be correct (at least in the matching loop).
4. Some minor simplifications in the TrajSeedMatcher

PR validation:

CMSSW compiles and local matrix tests pass.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29815/15325

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @rovere, @lgray, @sobhatta, @lecriste, @afiqaize, @varuns23 this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6261/console Started: 2020/05/12 22:45

[cmsbuild]

+1
Tested at: 971cbef
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c05286/6261/summary.html
CMSSW: CMSSW_11_1_X_2020-05-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c05286/6261/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697527
• DQMHistoTests: Total failures: 27
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697181
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[perrotta]

please test
(to refresh the tests)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6589/console Started: 2020/05/26 17:07

[cmsbuild]

+1
Tested at: 971cbef
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c05286/6589/summary.html
CMSSW: CMSSW_11_2_X_2020-05-26-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c05286/6589/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780739
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[perrotta]

+1

• Some simplification in the affected EGamma code, for which there were no complains from the EGamma contact and conveners which are observers in this github thread
• Computational performance remain untouched (tested on wf 136.874 RunEGamma2018C)
• Jenkins tests pass, and show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1