[RFC] Test clang-tidy --checks performance-unnecessary-value-param

[fwyzard]

See the description at https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-value-param.html .

[cmsbuild]

The code-checks are being triggered in jenkins.

[mrodozov]

-note
needed some fixes until get it in

[mrodozov]

@fwyzard I only need help with this one, the rest I got in. It needed more input before get it in, correct ?

[fwyzard]

Yes, we should review what this check is doing (and not doing).

Something that we did not discuss yesterday, maybe for the core software meeting: what is people's feeling about enabling some checks as "warning only" during the compilation step, without generating the automatic fixes ?

[mrodozov]

and so we put ourselves a reminder to ask that next Tuesday.
In the past we had warnings for which we didn't break the PR checks (code-checks or others)
I don't remember if there were some consequences following from that