Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation/Geometry: Fix TTree Option #30489

Merged
merged 2 commits into from
Jul 4, 2020
Merged

Conversation

vargasa
Copy link
Contributor

@vargasa vargasa commented Jul 1, 2020

PR description:

Enable output of TTree for Material budget studies

PR validation:

Unit test already present: Validation/Geometry/test/genTrackerPlots.sh

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30489/16666

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30489/16668

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

A new Pull Request was created by @vargasa (Andrés Vargas) for master.

It involves the following packages:

Validation/Geometry

@andrius-k, @Dr15Jones, @makortel, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @civanch can you please review it and eventually sign? Thanks.
@rovere, @apsallid, @lecriste, @rishabhCMS, @fabiocos, @rbartek this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 1, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

+1
Tested at: fb9e92f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-024676/7570/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-024676/7570/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2784120
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784069
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 2, 2020

+1

@cvuosalo
Copy link
Contributor

cvuosalo commented Jul 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d48470b into cms-sw:master Jul 4, 2020
@vargasa vargasa deleted the VGUnicornTree branch October 9, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants