-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal cleanup of PFClusterValidation code #30589
Conversation
Fixes #30588 . |
The code-checks are being triggered in jenkins. |
@cmsbuild, please test |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30589/16839
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
d90093b
to
85f95dc
Compare
@cmsbuild, please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30589/16841
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: Validation/RecoParticleFlow @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison job queued. |
The code-checks are being triggered in jenkins. |
Thanks for the comments @Dr15Jones , they should all be addressed in the last commit. |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30589/16850
|
The tests are being triggered in jenkins.
|
Pull request #30589 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Minimal clean up of the PFClusterValidation module, addressing various issues: - unsafe assumptions that could potentially "leak" information across events; - use of common functions instead of private redefinitions; - adherence to CMS coding rules; - make better use of const/constexpr variables.
Minimal clean up of the PFClusterValidation module, addressing various issues: