-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove further unused classes from DataFormats/GEMDigi #30609
Conversation
The code-checks are being triggered in jenkins. |
-code-checks ERROR: Build errors found during clang-tidy run.
|
I don't think this is due to me. I added this onto a branch that was previously merged into master, could that cause an issue? |
@smuzaffar - seems code checks are not working this morning
On Jul 9, 2020, at 8:20 AM, cmsbuild <notifications@github.com<mailto:notifications@github.com>> wrote:
…-code-checks
ERROR: Build errors found during clang-tidy run.
gmake: *** [tmp/slc7_amd64_gcc820/Makefile:32: .SCRAM/slc7_amd64_gcc820/timestamps/clhepheader] Error 1
gzip: /build/cmsbld/jenkins/workspace/run-pr-code-checks/CMSSW_11_2_X_2020-07-08-2300/.SCRAM/slc7_amd64_gcc820/ToolCache.db.gz: unexpected end of file
Can't call method "initpathvars" on an undefined value at /cvmfs/cms-ib.cern.ch/nweek-02636/share/lcg/SCRAMV1/V2_2_9_pre07/src/SCRAM/SCRAM.pm<http://cms-ib.cern.ch/nweek-02636/share/lcg/SCRAMV1/V2_2_9_pre07/src/SCRAM/SCRAM.pm> line 392.
--
gmake: *** [tmp/slc7_amd64_gcc820/Makefile:32: .SCRAM/slc7_amd64_gcc820/timestamps/clhep] Error 1
Finding a value for CORAL_BASE:
--
gmake: *** No rule to make target 'code-checks'.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#30609 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQZS7JXRYGGHV6UQKMLR2VORFANCNFSM4OVHXWKA>.
|
code-checks |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30609/16900
|
A new Pull Request was created by @watson-ij (Ian J. Watson) for master. It involves the following packages: DataFormats/GEMDigi @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Per #30586 removing further unused classes DataFormats/GEMDigi/GEMAMCStatusDigi and GEMGEBStatusDigi. These classes are older unused versions of replacements in EventFilter/GEMRawToDigi.
@jshlee @quark2 @hyunyong @davidlange6
PR validation:
Checked run the matrix on the 2021 10mu workflow 11621.0 runs without issue after removing the classes.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: