-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up BuildFiles under Calibration/ #29648
Clean up BuildFiles under Calibration/ #29648
Conversation
@cmsbuild, please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29648/15044
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: Calibration/EcalAlCaRecoProducers @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
bbd97d9
to
ba8c44a
Compare
The code-checks are being triggered in jenkins. |
-1 Tested at: bbd97d9 CMSSW: CMSSW_11_1_X_2020-05-04-2300 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: /cvmfs/cms-ib.cern.ch/nweek-02627/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: PUDumper.cc:(.text+0x4c4): undefined reference to `TFileDirectory::_cd(std::__cxx11::basic_string, std::allocator > const&, bool) const' /cvmfs/cms-ib.cern.ch/nweek-02627/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: PUDumper.cc:(.text+0x52a): undefined reference to `TH1AddDirectorySentry::TH1AddDirectorySentry()' /cvmfs/cms-ib.cern.ch/nweek-02627/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: PUDumper.cc:(.text+0x53b): undefined reference to `TH1AddDirectorySentry::~TH1AddDirectorySentry()' /cvmfs/cms-ib.cern.ch/nweek-02627/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc820/src/Calibration/EcalAlCaRecoProducers/plugins/CalibrationEcalAlCaRecoProducersAuto/PUDumper.cc.o: in function `PUDumper::PUDumper(edm::ParameterSet const&) [clone .cold.151]': PUDumper.cc:(.text.unlikely+0x3f): undefined reference to `TH1AddDirectorySentry::~TH1AddDirectorySentry()' collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc820/src/Calibration/EcalAlCaRecoProducers/plugins/CalibrationEcalAlCaRecoProducersAuto/libCalibrationEcalAlCaRecoProducersAuto.so] Error 1 Leaving library rule at src/Calibration/EcalAlCaRecoProducers/plugins Entering library rule at Calibration/EcalAlCaRecoProducers >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-04-2300/src/Calibration/EcalAlCaRecoProducers/src/ValueMapTraslator.cc >> Building shared library tmp/slc7_amd64_gcc820/src/Calibration/EcalAlCaRecoProducers/src/CalibrationEcalAlCaRecoProducers/libCalibrationEcalAlCaRecoProducers.so The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29648/15048
|
hold |
Pull request has been put on hold by @fwyzard |
Clean up BuildFile.xml filea with `xmllint --format`.
ba8c44a
to
ae105ae
Compare
The code-checks are being triggered in jenkins. |
unhold |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29648/15150
|
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
<use name="Geometry/CaloGeometry"/> | ||
<use name="CalibTracker/Records"/> | ||
<flags EDM_PLUGIN="1"/> | ||
<use name="clhep"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the comment and sorted
merge |
Clean up BuildFile.xml filea with
xmllint --format
.