[LLVM10] OnlineDB fix clang warnings

[mrodozov]

PR description:

Fixes clang warnings.

PR validation:

Builds without warnings with CLANG IB

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29583/14902

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

OnlineDB/EcalCondDB
OnlineDB/SiStripConfigDb

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@erikbutz, @mmusich, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

please test for CMSSW_11_1_CLANG_X

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• RELEASE_FORMAT = CMSSW_11_1_CLANG_X
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5902/console Started: 2020/04/29 16:15

[cmsbuild]

+1
Tested at: 4438591
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e1591/5902/summary.html
CMSSW: CMSSW_11_1_CLANG_X_2020-04-28-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e1591/5902/summary.html

Comparison Summary:

• You potentially added 5010 lines to the logs
• Reco comparison results: 13853 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696435
• DQMHistoTests: Total failures: 114638
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 2581472
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.016 KiB( 33 files compared)
• DQMHistoSizes: changed ( 136.793 ): -0.020 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 4.53 ): 0.004 KiB JetMET/SUSYDQM
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5927/console Started: 2020/04/30 12:40

[cmsbuild]

+1
Tested at: 4438591
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e1591/5927/summary.html
CMSSW: CMSSW_11_1_X_2020-04-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e1591/5927/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696435
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696114
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[silviodonato]

merge
@ggovi please let me know if you have any objections