-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up BuildFiles under CalibCalorimetry/ #29649
Clean up BuildFiles under CalibCalorimetry/ #29649
Conversation
@cmsbuild, please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29649/15046
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: CalibCalorimetry/CaloMiscalibTools @benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Clean up BuildFile.xml filea with `xmllint --format`.
5f0775b
to
cc6b31f
Compare
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29649/15151
|
The tests are being triggered in jenkins. |
Pull request #29649 was updated. @benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @tlampen, @pohsun can you please check and sign again. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
<use name="CalibCalorimetry/EcalCorrelatedNoiseAnalysisAlgos"/> | ||
<use name="root"/> | ||
<flags EDM_PLUGIN="1"/> | ||
#<export> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was commented out, I removed it
<use name="CalibCalorimetry/EcalTPGTools"/> | ||
<use name="OnlineDB/EcalCondDB"/> | ||
<use name="OnlineDB/Oracle"/> | ||
#<bin file="changeTPGLutThreshold.cpp"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was commented out, I removed it
merge |
Clean up BuildFile.xml filea with
xmllint --format
.