Add time support to IPCutPFCandidateSelector

[dntaylor]

PR description:

This is a simple addition to the IPCutPFCandidateSelector to allow a filter on the delta time or time significance of particle flow candidates relative to the first primary vertex.

An example usage would be:

process.pfAllInTimeChargedHadrons = cms.EDFilter("IPCutPFCandidateSelector",
    d0Cut = cms.double(-1),
    d0SigCut = cms.double(-1),
    dtCut = cms.double(-1),
    dtSigCut = cms.double(3.0),
    dzCut = cms.double(-1),
    dzSigCut = cms.double(-1),
    src = cms.InputTag("pfAllChargedHadrons"),
    vertices = cms.InputTag("offlinePrimaryVertices4D")
)

This is a first part in adding timing to isolation sums.

PR validation:

Ran most of the following (before my kinit ran out, but its a simple change and the early ones succeeded):

runTheMatrix.py -l limited -i all --ibeos

Also ran on a phase-II sample with MTD timing available in particleFlow,
modifying the muon pfIsolation charged hadron inputs to be the in time charged hadrons
(rather than all charged hadrons) and correctly observe a reduction in PF isolation energy.
It is not yet decided if this will be used.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29596/14928

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29596/14928/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29596/14928/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29596/14935

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dntaylor (Devin Taylor) for master.

It involves the following packages:

CommonTools/ParticleFlow

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @riga, @cbernet, @jdolen, @gkasieczka, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5931/console Started: 2020/04/30 14:24

[cmsbuild]

+1
Tested at: deef0a6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae5311/5931/summary.html
CMSSW: CMSSW_11_1_X_2020-04-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae5311/5931/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696239
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2695918
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[perrotta]

+1

• Timing and timing error added as possible parameters to select on
• Default settings do not use them
• Jenkins tests pass

[silviodonato]

merge
@santocch please let me know if you have any objections

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.