Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean buildfiles in DQM #29579

Merged
merged 1 commit into from
May 5, 2020
Merged

Clean buildfiles in DQM #29579

merged 1 commit into from
May 5, 2020

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #29541), this time covering all DQM subsystems.

In a few files, I added previously missing includes that were previously gotten indirectly, such that the BuildFile cleaning script does not give false positives.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Apr 28, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29579/14893

  • This PR adds an extra 96KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

DQM/BeamMonitor
DQM/CastorMonitor
DQM/DTMonitorClient
DQM/DTMonitorModule
DQM/DataScouting
DQM/EcalCommon
DQM/EcalMonitorClient
DQM/EcalMonitorDbModule
DQM/EcalMonitorTasks
DQM/EcalPreshowerMonitorClient
DQM/EcalPreshowerMonitorModule
DQM/HLXMonitor
DQM/HcalCommon
DQM/HcalTasks
DQM/Integration
DQM/L1TMonitor
DQM/L1TMonitorClient
DQM/Physics
DQM/PhysicsObjectsMonitoring
DQM/RPCMonitorDigi
DQM/SiOuterTracker
DQM/SiPixelCommon
DQM/SiPixelMonitorClient
DQM/SiPixelMonitorCluster
DQM/SiPixelMonitorDigi
DQM/SiPixelMonitorRawData
DQM/SiPixelMonitorRecHit
DQM/SiPixelMonitorTrack
DQM/SiPixelPhase1Common
DQM/SiPixelPhase1Summary
DQM/SiPixelPhase1Track
DQM/SiStripCommissioningClients
DQM/SiStripCommissioningDbClients
DQM/SiStripMonitorClient
DQM/SiStripMonitorCluster
DQM/SiStripMonitorDigi
DQM/SiStripMonitorHardware
DQM/SiStripMonitorPedestals
DQM/SiStripMonitorSummary
DQM/SiStripMonitorTrack
DQM/SiTrackerPhase2
DQM/TrackerCommon
DQM/TrackerMonitorTrack
DQM/TrackingMonitor
DQM/TrackingMonitorClient
DQM/TrackingMonitorSource
DQM/TrigXMonitor
DQM/TrigXMonitorClient
DQMOffline/Alignment
DQMOffline/CalibCalo
DQMOffline/CalibMuon
DQMOffline/CalibTracker
DQMOffline/EGamma
DQMOffline/Ecal
DQMOffline/Hcal
DQMOffline/JetMET
DQMOffline/L1Trigger
DQMOffline/Lumi
DQMOffline/Muon
DQMOffline/PFTau
DQMOffline/RecoB
DQMOffline/Trigger
DQMServices/Components
DQMServices/Demo
DQMServices/Examples
DQMServices/FileIO
DQMServices/StreamerIO

@benkrikler, @kmaeshima, @schneiml, @andrius-k, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@erikbutz, @rappoccio, @jandrea, @emilbols, @missirol, @argiro, @fioriNTU, @ahinzmann, @threus, @seemasharmafnal, @venturia, @acimmino, @mmarionncern, @kreczko, @hdelanno, @calderona, @makortel, @smoortga, @jhgoh, @jdolen, @HuguesBrun, @cericeci, @ferencek, @trocino, @rociovilar, @abbiendi, @barvic, @DryRun, @rovere, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @schoef, @idebruyn, @ptcox, @mtosi, @andrzejnovak, @clelange, @batinkov, @battibass, @Fedespring, @JyothsnaKomaragiri, @mverzett, @lecriste, @mariadalfonso, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5895/console Started: 2020/04/29 09:56

@cmsbuild
Copy link
Contributor

+1
Tested at: 503aa3e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093317/5895/summary.html
CMSSW: CMSSW_11_1_X_2020-04-28-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093317/5895/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696086
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

Kind reminder @rekovic

@silviodonato
Copy link
Contributor

merge
@rekovic please let me know if you have any objections

@cmsbuild cmsbuild merged commit 09a0747 into cms-sw:master May 5, 2020
@guitargeek guitargeek deleted the deps_dqm branch May 5, 2020 10:28
This was referenced May 5, 2020
Merged
Merged
Merged
Merged
Merged
Merged
@guitargeek guitargeek mentioned this pull request May 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available dqm-approved l1-pending orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@guitargeek @cmsbuild @jfernan2 @silviodonato