[GCC13] Patch applied for c++20

[smuzaffar]

We can not move to GCC 13.3.0 yet as cuda does not support it ( see #9270 ). This PR proposes to apply gcc-mirror/gcc@96482ff which is needed to avoid build errors with c++20 standard

[cmsbuild]

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/g13.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[smuzaffar]

test parameters:

• full_cmssw = true

[smuzaffar]

please test with #9288 for el9_amd64_gcc13

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-612516/40337/summary.html
COMMIT: 8917471
CMSSW: CMSSW_14_1_X_2024-07-05-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9295/40337/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @fwyzard Add a test for the dependency on host-only types from alpaka libraries cmssw#45285
• @dan131riley CTPPS validation: workaround for -O3 ASAN compilation issue cmssw#45304
• @iarspider Update RemoteFile::local cmssw#45327
• @rdelliga Update of MTD validation: 4D vertices association with truth cmssw#45343
• @Mmiglio L1 Scouting Online Selection modules cmssw#45350
• @bsunanda Phase2-hgx358A Fix a bug in the conversion code for HGCal scintillator xml files cmssw#45364
• @bsunanda Phase2-hgx358B Modify the name of the class HGCPassive to HGCalTBPassive to separate the names of TB and non-TB classes of HGCal cmssw#45365
• @fwyzard Fix CachingAllocator debug for non-async operations cmssw#45368
• @stahlleiton Update HLTPixelTrackFilter to store candidates cmssw#45373
• @bsunanda Run3-alca247D Avoid potential memory leakage comments in the declaration of new histograms cmssw#45378
• @fwyzard Update the GPU alpaka workflows cmssw#45379
• @srimanob Add 2023 and 2024 TT PU Prodlike in relval_2017 cmssw#45381
• @bsunanda Phase2-hgx358D Correct the XML file for scintillators in the V19 description of HGCal geometry cmssw#45382
• @bsunanda Phase2-hgx358E Update the DetId for HGCal scintillator in view of changes for the V19 version of HGCal geometry cmssw#45383
• @mmusich ObjectSelectorBase add option to not throw on missing input cmssw#45385
• @jking79 Updated EcalUncalibRecHitTimingCCAlgo to correct for bias at high energies cmssw#45386
• @francescobrivio New SimBeamSpotHLLHC tags in Phase-2 MC GT and make Phase-2 workflows consume it cmssw#45387
• @perrotta Update GTs and modifiers for L1T 2024 menu L1Menu_Collisions2024_v1_3_0_xml cmssw#45389
• @kandrosov Catch VertexException in PATLeptonTimeLifeInfoProducer when fitVertex fails cmssw#45393
• @VinInn fix syntax error in TTStub.h cmssw#45399
• @makortel Avoid releasing WaitingTask too early in case of exception in WaitingThreadPool cmssw#45402
• @Dr15Jones Add OutputModule test for TestProcessor cmssw#45404
• @kaderci-johannes Make nTS loops configurable cmssw#45406
• @mseidel42 Fix NanoGen with Rivet4 cmssw#45411
• @bsunanda Run3-alca247E Modify the macro for getting IsoTrack Calibration for HCAL cmssw#45418
• @artlbv Add SC8 jets to L1T event content cmssw#45425

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-612516/40337/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-612516/40337/git-merge-result

Build

I found compilation error when building:

    inlined from 'ndLoopImpl' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el9_amd64_gcc13/external/alpaka/1.1.0-5c60ee703be9eb3e5e623403758d8410/include/alpaka/meta/NdLoop.hpp:25:14,
    inlined from 'ndLoopImpl' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el9_amd64_gcc13/external/alpaka/1.1.0-5c60ee703be9eb3e5e623403758d8410/include/alpaka/meta/NdLoop.hpp:44:27,
    inlined from 'ndLoop' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el9_amd64_gcc13/external/alpaka/1.1.0-5c60ee703be9eb3e5e623403758d8410/include/alpaka/meta/NdLoop.hpp:71:27,
    inlined from 'ndLoopIncIdx' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el9_amd64_gcc13/external/alpaka/1.1.0-5c60ee703be9eb3e5e623403758d8410/include/alpaka/meta/NdLoop.hpp:83:15,
    inlined from 'operator()' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el9_amd64_gcc13/external/alpaka/1.1.0-5c60ee703be9eb3e5e623403758d8410/include/alpaka/kernel/TaskKernelCpuSerial.hpp:86:31:
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:15:60: error: array subscript 262145 is above array bounds of 'const unsigned int[262145]' [-Werror=array-bounds=]
   15 |     constexpr const I& operator[](int i) const { return m_v[i]; }
      |                                                            ^
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h: In member function 'operator()':
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:21:7: note: while referencing 'm_v'
   21 |     I m_v[S];


[smuzaffar]

+externals

lets get this in for c++20

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/g13 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Pull request #9295 was updated.

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-612516/40357/summary.html
COMMIT: 603181f
CMSSW: CMSSW_14_1_X_2024-07-05-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9295/40357/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @fwyzard Add a test for the dependency on host-only types from alpaka libraries cmssw#45285
• @dan131riley CTPPS validation: workaround for -O3 ASAN compilation issue cmssw#45304
• @iarspider Update RemoteFile::local cmssw#45327
• @rdelliga Update of MTD validation: 4D vertices association with truth cmssw#45343
• @Mmiglio L1 Scouting Online Selection modules cmssw#45350
• @bsunanda Phase2-hgx358A Fix a bug in the conversion code for HGCal scintillator xml files cmssw#45364
• @bsunanda Phase2-hgx358B Modify the name of the class HGCPassive to HGCalTBPassive to separate the names of TB and non-TB classes of HGCal cmssw#45365
• @fwyzard Fix CachingAllocator debug for non-async operations cmssw#45368
• @stahlleiton Update HLTPixelTrackFilter to store candidates cmssw#45373
• @bsunanda Run3-alca247D Avoid potential memory leakage comments in the declaration of new histograms cmssw#45378
• @fwyzard Update the GPU alpaka workflows cmssw#45379
• @srimanob Add 2023 and 2024 TT PU Prodlike in relval_2017 cmssw#45381
• @bsunanda Phase2-hgx358D Correct the XML file for scintillators in the V19 description of HGCal geometry cmssw#45382
• @bsunanda Phase2-hgx358E Update the DetId for HGCal scintillator in view of changes for the V19 version of HGCal geometry cmssw#45383
• @mmusich ObjectSelectorBase add option to not throw on missing input cmssw#45385
• @jking79 Updated EcalUncalibRecHitTimingCCAlgo to correct for bias at high energies cmssw#45386
• @francescobrivio New SimBeamSpotHLLHC tags in Phase-2 MC GT and make Phase-2 workflows consume it cmssw#45387
• @perrotta Update GTs and modifiers for L1T 2024 menu L1Menu_Collisions2024_v1_3_0_xml cmssw#45389
• @kandrosov Catch VertexException in PATLeptonTimeLifeInfoProducer when fitVertex fails cmssw#45393
• @VinInn fix syntax error in TTStub.h cmssw#45399
• @makortel Avoid releasing WaitingTask too early in case of exception in WaitingThreadPool cmssw#45402
• @Dr15Jones Add OutputModule test for TestProcessor cmssw#45404
• @kaderci-johannes Make nTS loops configurable cmssw#45406
• @mseidel42 Fix NanoGen with Rivet4 cmssw#45411
• @bsunanda Run3-alca247E Modify the macro for getting IsoTrack Calibration for HCAL cmssw#45418
• @artlbv Add SC8 jets to L1T event content cmssw#45425

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-612516/40357/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-612516/40357/git-merge-result

Build

I found compilation error when building:

    inlined from 'ndLoopImpl' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el9_amd64_gcc13/external/alpaka/1.1.0-5ac77778df5c635a47f96d0942a6db3a/include/alpaka/meta/NdLoop.hpp:25:14,
    inlined from 'ndLoopImpl' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el9_amd64_gcc13/external/alpaka/1.1.0-5ac77778df5c635a47f96d0942a6db3a/include/alpaka/meta/NdLoop.hpp:44:27,
    inlined from 'ndLoop' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el9_amd64_gcc13/external/alpaka/1.1.0-5ac77778df5c635a47f96d0942a6db3a/include/alpaka/meta/NdLoop.hpp:71:27,
    inlined from 'ndLoopIncIdx' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el9_amd64_gcc13/external/alpaka/1.1.0-5ac77778df5c635a47f96d0942a6db3a/include/alpaka/meta/NdLoop.hpp:83:15,
    inlined from 'operator()' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el9_amd64_gcc13/external/alpaka/1.1.0-5ac77778df5c635a47f96d0942a6db3a/include/alpaka/kernel/TaskKernelCpuSerial.hpp:86:31:
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:15:60: error: array subscript 262145 is above array bounds of 'const unsigned int[262145]' [-Werror=array-bounds=]
   15 |     constexpr const I& operator[](int i) const { return m_v[i]; }
      |                                                            ^
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h: In member function 'operator()':
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:21:7: note: while referencing 'm_v'
   21 |     I m_v[S];