Update RemoteFile::local #45327

iarspider · 2024-06-27T11:55:24Z

PR description:

Got rid of Wunused-result (from call to c_str())
Since C-string &(temp[0]) is not guaranteed by C++ standard to be null-terminated (but, I think, GCC's implementation kind of guarantees this), copy string template into a vector, explicitly add \0 and pass it to mkstemp. Only c_str() is guaranteed to return null-terminated string, but writing to the character array accessed through c_str() is undefined behavior.
Replaced call to getcwd with C++17 filesystem API

PR validation:

Bot tests

cmsbuild · 2024-06-27T11:55:43Z

cms-bot internal usage

cmsbuild · 2024-06-27T12:00:06Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45327/40744

This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45327/40744/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45327/40744/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

* Replaced call to `getcwd` with C++17 filesystem API * Got rid of `Wunused-result` (from call to c_str) * Since C-string `&(temp[0])` is not guaranteed by C++ standard to be null-terminated (but, I think, GCC's implementation kind of guarantees this), copy string template into a vector, explicitly add `\0` and pass it to `mkstemp`.

iarspider · 2024-06-27T12:05:02Z

please test

cmsbuild · 2024-06-27T12:11:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45327/40746

This PR adds an extra 16KB to repository

cmsbuild · 2024-06-27T12:11:24Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

Utilities/StorageFactory (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Utilities/StorageFactory/src/RemoteFile.cc

cmsbuild · 2024-06-27T13:09:46Z

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-556b13/40121/summary.html
COMMIT: 250cec2
CMSSW: CMSSW_14_1_X_2024-06-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45327/40121/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  src/Utilities/StorageFactory/src/Throw.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_1_X_2024-06-27-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_1_X_2024-06-27-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/boost/1.80.0-a1544032d9d65904ac2112b6d35bba55/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/lcg/root/6.30.07-5b5d83179d6ed7bc60aa7a5006899eba/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/tbb/v2021.9.0-1dc6d66b4b014f4ae4733b04914ce7d4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/fmt/8.0.1-258b4791803c34b7e98cf43693e54d87/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/tinyxml2/6.2.0-88fe0ec301baf763fa3c485e5b67ed91/include -D_FILE_OFFSET_BITS=64 -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++17 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/Utilities/StorageFactory/src/UtilitiesStorageFactory/Throw.cc.d src/Utilities/StorageFactory/src/Throw.cc -o tmp/el8_amd64_gcc12/src/Utilities/StorageFactory/src/UtilitiesStorageFactory/Throw.cc.o
>> Compiling  src/Utilities/StorageFactory/src/UnixFile.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_1_X_2024-06-27-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_1_X_2024-06-27-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/boost/1.80.0-a1544032d9d65904ac2112b6d35bba55/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/lcg/root/6.30.07-5b5d83179d6ed7bc60aa7a5006899eba/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/tbb/v2021.9.0-1dc6d66b4b014f4ae4733b04914ce7d4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/fmt/8.0.1-258b4791803c34b7e98cf43693e54d87/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/tinyxml2/6.2.0-88fe0ec301baf763fa3c485e5b67ed91/include -D_FILE_OFFSET_BITS=64 -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++17 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/Utilities/StorageFactory/src/UtilitiesStorageFactory/UnixFile.cc.d src/Utilities/StorageFactory/src/UnixFile.cc -o tmp/el8_amd64_gcc12/src/Utilities/StorageFactory/src/UtilitiesStorageFactory/UnixFile.cc.o
src/Utilities/StorageFactory/src/RemoteFile.cc: In static member function 'static int edm::storage::RemoteFile::local(const std::string&, std::string&)':
src/Utilities/StorageFactory/src/RemoteFile.cc:57:5: error: 'fs' has not been declared
   57 |     fs::path current_path = fs::current_path();
      |     ^~
src/Utilities/StorageFactory/src/RemoteFile.cc:58:12: error: 'current_path' was not declared in this scope; did you mean 'std::filesystem::current_path'?
   58 |     temp = current_path.string();
      |            ^~~~~~~~~~~~

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package Utilities/StorageFactory
>> Compile sequence completed for CMSSW CMSSW_14_1_X_2024-06-27-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-06-27-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Utilities/StorageFactory
>> Compiling  src/Utilities/StorageFactory/bin/anycp.cpp
Entering library rule at src/Utilities/StorageFactory/plugins

iarspider · 2024-06-30T10:42:34Z

please test

cmsbuild · 2024-06-30T16:53:24Z

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-556b13/40156/summary.html
COMMIT: 45a3bb0
CMSSW: CMSSW_14_1_X_2024-06-30-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45327/40156/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  src/Utilities/StorageFactory/src/Throw.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_1_X_2024-06-30-0000' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_1_X_2024-06-30-0000' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-06-30-0000/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/boost/1.80.0-a1544032d9d65904ac2112b6d35bba55/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/lcg/root/6.30.07-5b5d83179d6ed7bc60aa7a5006899eba/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/tbb/v2021.9.0-1dc6d66b4b014f4ae4733b04914ce7d4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/fmt/8.0.1-258b4791803c34b7e98cf43693e54d87/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/tinyxml2/6.2.0-88fe0ec301baf763fa3c485e5b67ed91/include -D_FILE_OFFSET_BITS=64 -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++17 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/Utilities/StorageFactory/src/UtilitiesStorageFactory/Throw.cc.d src/Utilities/StorageFactory/src/Throw.cc -o tmp/el8_amd64_gcc12/src/Utilities/StorageFactory/src/UtilitiesStorageFactory/Throw.cc.o
>> Compiling  src/Utilities/StorageFactory/src/UnixFile.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_1_X_2024-06-30-0000' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_1_X_2024-06-30-0000' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-06-30-0000/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/boost/1.80.0-a1544032d9d65904ac2112b6d35bba55/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/lcg/root/6.30.07-5b5d83179d6ed7bc60aa7a5006899eba/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/tbb/v2021.9.0-1dc6d66b4b014f4ae4733b04914ce7d4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/fmt/8.0.1-258b4791803c34b7e98cf43693e54d87/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02844/el8_amd64_gcc12/external/tinyxml2/6.2.0-88fe0ec301baf763fa3c485e5b67ed91/include -D_FILE_OFFSET_BITS=64 -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++17 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/Utilities/StorageFactory/src/UtilitiesStorageFactory/UnixFile.cc.d src/Utilities/StorageFactory/src/UnixFile.cc -o tmp/el8_amd64_gcc12/src/Utilities/StorageFactory/src/UtilitiesStorageFactory/UnixFile.cc.o
src/Utilities/StorageFactory/src/RemoteFile.cc: In static member function 'static int edm::storage::RemoteFile::local(const std::string&, std::string&)':
src/Utilities/StorageFactory/src/RemoteFile.cc:65:24: error: 'temdir' was not declared in this scope; did you mean 'rmdir'?
   65 |     temp_chars.reserve(temdir.size() + 30);
      |                        ^~~~~~
      |                        rmdir
gmake: *** [tmp/el8_amd64_gcc12/src/Utilities/StorageFactory/src/UtilitiesStorageFactory/RemoteFile.cc.o] Error 1
>> Building shared library tmp/el8_amd64_gcc12/src/Utilities/StorageFactory/src/UtilitiesStorageFactory/libUtilitiesStorageFactory.so

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package Utilities/StorageFactory
>> Compile sequence completed for CMSSW CMSSW_14_1_X_2024-06-30-0000
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-06-30-0000/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Utilities/StorageFactory
>> Compiling  src/Utilities/StorageFactory/bin/anycp.cpp
Entering library rule at src/Utilities/StorageFactory/plugins

iarspider · 2024-06-30T17:16:08Z

please test

cmsbuild · 2024-06-30T17:21:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45327/40768

This PR adds an extra 16KB to repository

cmsbuild · 2024-06-30T17:22:05Z

Pull request #45327 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

cmsbuild · 2024-06-30T21:26:57Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-556b13/40157/summary.html
COMMIT: 100f2e1
CMSSW: CMSSW_14_1_X_2024-06-30-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45327/40157/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2674 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345088
DQMHistoTests: Total failures: 1147
DQMHistoTests: Total nulls: 4
DQMHistoTests: Total successes: 3343917
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: found differences in 1 / 46 workflows

makortel · 2024-07-09T19:00:34Z

Comparison differences are in 29634.911, which is a "known" instability (although we don't seem to have a dedicated issue for that?)

makortel · 2024-07-09T19:00:37Z

+core

cmsbuild · 2024-07-09T19:00:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-07-11T14:11:19Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone Jun 27, 2024

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jun 27, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 27, 2024

iarspider force-pushed the patch-6 branch from 99d6e05 to 250cec2 Compare June 27, 2024 12:03

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 27, 2024

cmsbuild added tests-started and removed tests-pending labels Jun 27, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 27, 2024

Dr15Jones reviewed Jun 27, 2024

View reviewed changes

Utilities/StorageFactory/src/RemoteFile.cc Show resolved Hide resolved

cmsbuild added tests-rejected tests-pending code-checks-pending and removed tests-started tests-rejected code-checks-approved labels Jun 27, 2024

cmsbuild added tests-rejected and removed tests-started labels Jun 30, 2024

Changes from review - 2

100f2e1

iarspider force-pushed the patch-6 branch from 45a3bb0 to 100f2e1 Compare June 30, 2024 17:16

cmsbuild added tests-started code-checks-pending and removed tests-rejected code-checks-approved labels Jun 30, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 30, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 30, 2024

iarspider requested a review from Dr15Jones July 8, 2024 17:10

cmsbuild removed core-pending pending-signatures labels Jul 9, 2024

cmsbuild added core-approved fully-signed labels Jul 9, 2024

cmsbuild added orp-approved and removed orp-pending labels Jul 11, 2024

cmsbuild merged commit e2076b5 into cms-sw:master Jul 11, 2024
11 checks passed

cmsbuild mentioned this pull request Jul 11, 2024

[GCC13] Patch applied for c++20 cms-sw/cmsdist#9295

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update RemoteFile::local #45327

Update RemoteFile::local #45327

iarspider commented Jun 27, 2024 •

edited

Loading

cmsbuild commented Jun 27, 2024 •

edited

Loading

cmsbuild commented Jun 27, 2024

iarspider commented Jun 27, 2024

cmsbuild commented Jun 27, 2024

cmsbuild commented Jun 27, 2024

cmsbuild commented Jun 27, 2024

iarspider commented Jun 30, 2024

cmsbuild commented Jun 30, 2024

iarspider commented Jun 30, 2024

cmsbuild commented Jun 30, 2024

cmsbuild commented Jun 30, 2024

cmsbuild commented Jun 30, 2024

makortel commented Jul 9, 2024

makortel commented Jul 9, 2024

cmsbuild commented Jul 9, 2024

rappoccio commented Jul 11, 2024

Update RemoteFile::local #45327

Update RemoteFile::local #45327

Conversation

iarspider commented Jun 27, 2024 • edited Loading

PR description:

PR validation:

cmsbuild commented Jun 27, 2024 • edited Loading

cmsbuild commented Jun 27, 2024

iarspider commented Jun 27, 2024

cmsbuild commented Jun 27, 2024

cmsbuild commented Jun 27, 2024

cmsbuild commented Jun 27, 2024

Build

Clang Build

iarspider commented Jun 30, 2024

cmsbuild commented Jun 30, 2024

Build

Clang Build

iarspider commented Jun 30, 2024

cmsbuild commented Jun 30, 2024

cmsbuild commented Jun 30, 2024

cmsbuild commented Jun 30, 2024

Comparison Summary

makortel commented Jul 9, 2024

makortel commented Jul 9, 2024

cmsbuild commented Jul 9, 2024

rappoccio commented Jul 11, 2024

iarspider commented Jun 27, 2024 •

edited

Loading

cmsbuild commented Jun 27, 2024 •

edited

Loading