Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RemoteFile::local #45327

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Update RemoteFile::local #45327

merged 3 commits into from
Jul 11, 2024

Commits on Jun 27, 2024

  1. Update RemoteFile::local 

    * Replaced call to `getcwd` with C++17 filesystem API
* Got rid of `Wunused-result` (from call to c_str)
* Since C-string `&(temp[0])` is not guaranteed by C++ standard to be null-terminated (but, I think, GCC's implementation kind of guarantees this), copy string template into a vector, explicitly add `\0` and pass it to `mkstemp`.
    @iarspider
    iarspider committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    250cec2 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Changes from review

    @iarspider
    iarspider committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    f4cda45 View commit details
    Browse the repository at this point in the history

  2. Changes from review - 2

    @iarspider
    iarspider committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    100f2e1 View commit details
    Browse the repository at this point in the history