Catch VertexException in PATLeptonTimeLifeInfoProducer when fitVertex fails

[kandrosov]

PR description:

VertexException was occurring in PATLeptonTimeLifeInfoProducer when fitVertex failed. This PR fixes the issue by catching such exceptions in the fitVertex method and returning false.
How to reproduce exception:

edmCopyPickMerge outputFile=mini.root inputFiles=/store/mc/Run3Summer22MiniAODv4/DYto2L-2Jets_MLL-50_TuneCP5_13p6TeV_amcatnloFXFX-pythia8/MINIAODSIM/130X_mcRun3_2022_realistic_v5-v2/30000/d8195b83-9e92-4dd4-b286-dc358ec9568a.root eventsToProcess=1:26427:49708440
cmsDriver.py nano --filein file:mini.root --fileout file:nano.root --eventcontent NANOAODSIM --datatier NANOAODSIM --step NANO --nThreads 1 --conditions auto:phase1_2022_realistic --era Run3 --mc -n -1

Exception message:

----- Begin Fatal Exception 06-Jul-2024 07:38:06 CEST-----------------------
An exception of category 'VertexException' occurred while
   [0] Processing  Event run: 1 lumi: 26427 event: 49708440 stream: 0
   [1] Running path 'NANOAODSIMoutput_step'
   [2] Prefetching for module NanoAODOutputModule/'NANOAODSIMoutput'
   [3] Prefetching for module SimplePATTau2TrackTimeLifeInfoFlatTableProducer/'tauTimeLifeInfoTable'
   [4] Calling method for module PATTauTimeLifeInfoProducer/'tauTimeLifeInfos'
Exception Message:
BasicSingleVertexState::could not invert weight matrix
----- End Fatal Exception -------------------------------------------------

No changes to the output are expected.

PR validation:

Validated on several miniAOD files in CMSSW_14_0_6_patch1 and CMSSW_14_1_0_pre5 releases, for which the processing was originally failing due to the exception described above.

FYI @mbluj

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45393/40844

[cmsbuild]

A new Pull Request was created by @kandrosov for master.

It involves the following packages:

• PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @demuller, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[hqucms]

enable nano

[hqucms]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12628d/40269/summary.html
COMMIT: ca21101
CMSSW: CMSSW_14_1_X_2024-07-05-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45393/40269/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345088
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3345065
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 17023
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 17023
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 57 log files, 34 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.783	2.783	0.000 ( +0.0% )	3.27	3.23	+1.5%	5.960	6.657
2500.001	2.897	2.897	0.000 ( +0.0% )	2.91	2.88	+0.9%	6.323	6.755
2500.002	2.843	2.843	0.000 ( +0.0% )	3.04	2.98	+2.1%	6.258	6.886
2500.01	1.446	1.446	0.000 ( +0.0% )	5.61	5.53	+1.4%	2.245	2.389
2500.011	1.906	1.906	0.000 ( +0.0% )	3.04	3.06	-0.7%	2.402	2.569
2500.012	1.761	1.761	0.000 ( +0.0% )	4.41	4.41	-0.0%	2.390	2.489
2500.1	2.353	2.353	0.000 ( +0.0% )	4.14	4.06	+2.0%	5.962	6.579
2500.2	2.459	2.459	0.000 ( +0.0% )	4.69	4.57	+2.8%	5.948	6.571
2500.21	1.285	1.285	0.000 ( +0.0% )	3.05	3.00	+1.7%	2.184	2.304
2500.211	1.668	1.668	0.000 ( +0.0% )	2.83	2.73	+3.8%	2.215	2.381
2500.3	2.229	2.229	0.000 ( +0.0% )	8.61	8.01	+7.4%	5.895	6.534
2500.301	2.833	2.833	0.000 ( +0.0% )	7.92	7.29	+8.6%	2.431	2.430
2500.31	7.164	7.164	0.000 ( +0.0% )	1.50	1.43	+5.0%	1.710	1.714
2500.311	1.568	1.568	0.000 ( +0.0% )	8.73	8.27	+5.6%	1.056	1.063
2500.312	540.338	540.338	0.000 ( +0.0% )	0.53	0.50	+6.3%	1.660	1.678
2500.313	816.269	816.269	0.000 ( +0.0% )	0.76	0.71	+7.4%	1.642	1.640
2500.32	1.348	1.348	0.000 ( +0.0% )	10.12	9.83	+2.9%	2.190	2.380
2500.321	1.757	1.757	0.000 ( +0.0% )	8.95	8.57	+4.5%	2.385	2.456
2500.322	1.236	1.236	0.000 ( +0.0% )	8.71	8.38	+4.0%	2.206	2.284
2500.323	7.642	7.642	0.000 ( +0.0% )	4.04	3.77	+7.1%	1.941	1.950
2500.324	1.874	1.874	0.000 ( +0.0% )	8.62	8.44	+2.2%	2.145	2.364
2500.325	4.136	4.136	0.000 ( +0.0% )	4.03	3.94	+2.4%	2.143	2.382
2500.326	3.342	3.342	0.000 ( +0.0% )	1.45	1.41	+2.7%	1.774	2.322
2500.327	1.811	1.811	0.000 ( +0.0% )	8.68	8.28	+4.8%	1.778	2.364
2500.328	3.364	3.364	0.000 ( +0.0% )	1.33	1.30	+2.3%	1.810	2.347
2500.4	2.374	2.374	0.000 ( +0.0% )	8.03	7.79	+3.0%	5.376	6.078
2500.401	1.891	1.891	0.000 ( +0.0% )	7.53	7.38	+1.9%	2.161	2.346
2500.402	2.950	2.950	0.000 ( +0.0% )	7.33	7.33	-0.0%	2.182	2.397
2500.403	8.700	8.700	0.000 ( +0.0% )	2.62	2.67	-1.7%	2.199	2.415
2500.404	5.474	5.474	0.000 ( +0.0% )	1.07	1.05	+2.1%	2.292	2.490
2500.405	2.860	2.860	0.000 ( +0.0% )	7.52	7.20	+4.5%	2.187	2.392
2500.406	5.491	5.491	0.000 ( +0.0% )	1.01	1.00	+0.5%	2.437	2.528
2500.5	5.194	5.194	0.000 ( +0.0% )	16.09	15.36	+4.8%	1.429	1.533
2500.51	9.120	9.120	0.000 ( +0.0% )	9.72	9.54	+1.9%	1.401	1.481

[hqucms]

+1

[hqucms]

@kandrosov Thanks a lot for the fix! Could you please make a backport to 14_0_X?

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1