Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NanoGen with Rivet4 #45411

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix NanoGen with Rivet4 #45411

merged 1 commit into from
Jul 11, 2024

Conversation

mseidel42
Copy link
Contributor

PR description:

Fixes #44603 (comment)

  • Need to convert HepMC2 -> GenParticles -> HepMC3

PR validation:

% runTheMatrix.py -l 546.0 --ibeos -t 4
...
1 1 tests passed, 0 0 failed

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

A new Pull Request was created by @mseidel42 for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms, @vlimant can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Jul 9, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Jul 9, 2024

please test workflow 546.0,547.0,548.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a99377/40302/summary.html
COMMIT: 9eab131
CMSSW: CMSSW_14_1_X_2024-07-09-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45411/40302/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
546.0 step 2
547.0 step 3
548.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 484 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345094
  • DQMHistoTests: Total failures: 860
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3344214
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 210 log files, 173 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 57 log files, 34 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.26 1.46 +122.8% 5.934 6.034
2500.001 2.897 2.897 0.000 ( +0.0% ) 2.89 1.31 +120.1% 6.264 6.413
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.01 1.36 +120.4% 6.244 6.367
2500.01 1.446 1.446 0.000 ( +0.0% ) 5.67 2.80 +102.3% 1.935 2.149
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.08 1.50 +105.4% 1.963 2.164
2500.012 1.761 1.761 0.000 ( +0.0% ) 4.47 2.20 +103.3% 2.351 2.197
2500.1 2.353 2.353 0.000 ( +0.0% ) 4.11 1.99 +106.8% 5.888 5.981
2500.2 2.459 2.459 0.000 ( +0.0% ) 4.71 2.32 +102.8% 5.871 5.976
2500.21 1.285 1.285 0.000 ( +0.0% ) 3.03 1.61 +87.7% 1.784 1.991
2500.211 1.668 1.668 0.000 ( +0.0% ) 2.85 2.19 +30.3% 1.880 2.089
2500.3 2.229 2.229 0.000 ( +0.0% ) 8.70 4.42 +96.9% 5.846 5.935
2500.301 2.833 2.833 0.000 ( +0.0% ) 7.90 5.91 +33.7% 2.158 2.451
2500.31 7.164 7.164 0.000 ( +0.0% ) 1.53 1.16 +31.6% 1.722 1.721
2500.311 1.568 1.568 0.000 ( +0.0% ) 8.83 7.72 +14.3% 1.069 1.065
2500.312 540.338 540.338 0.000 ( +0.0% ) 0.54 0.44 +22.0% 1.598 1.674
2500.313 816.269 816.269 0.000 ( +0.0% ) 0.76 0.63 +20.0% 1.593 1.653
2500.32 1.348 1.348 0.000 ( +0.0% ) 10.23 6.44 +59.0% 1.759 2.393
2500.321 1.757 1.757 0.000 ( +0.0% ) 8.99 7.17 +25.5% 2.259 2.474
2500.322 1.236 1.236 0.000 ( +0.0% ) 8.92 7.14 +25.0% 2.124 2.299
2500.323 7.642 7.642 0.000 ( +0.0% ) 4.04 3.56 +13.7% 1.821 1.955
2500.324 1.874 1.874 0.000 ( +0.0% ) 8.73 7.11 +22.9% 2.159 2.374
2500.325 4.136 4.136 0.000 ( +0.0% ) 3.98 3.20 +24.5% 2.150 2.391
2500.326 3.342 3.342 0.000 ( +0.0% ) 1.48 0.97 +52.5% 2.201 2.019
2500.327 1.811 1.811 0.000 ( +0.0% ) 8.77 7.27 +20.7% 2.153 2.382
2500.328 3.364 3.364 0.000 ( +0.0% ) 1.36 0.81 +67.9% 2.107 2.045
2500.4 2.374 2.374 0.000 ( +0.0% ) 8.27 3.76 +120.2% 5.929 5.477
2500.401 1.891 1.891 0.000 ( +0.0% ) 7.74 5.29 +46.2% 2.174 2.349
2500.402 2.950 2.950 0.000 ( +0.0% ) 7.65 4.93 +55.1% 2.190 2.153
2500.403 8.700 8.700 0.000 ( +0.0% ) 2.81 1.44 +95.6% 2.203 2.053
2500.404 5.474 5.474 0.000 ( +0.0% ) 1.07 0.55 +93.4% 2.294 2.054
2500.405 2.860 2.860 0.000 ( +0.0% ) 7.35 4.80 +53.0% 2.193 2.118
2500.406 5.491 5.491 0.000 ( +0.0% ) 1.00 0.49 +106.3% 2.324 2.050
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.74 10.11 +55.7% 1.493 1.480
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.69 5.83 +66.2% 1.367 1.466

@hqucms
Copy link
Contributor

hqucms commented Jul 9, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 43d4c02 into cms-sw:master Jul 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants