-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SC8 jets to L1T event content #45425
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45425/40876 |
A new Pull Request was created by @artlbv for master. It involves the following packages:
@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+1 Size: This PR adds an extra 20KB to repository
Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
hm there is one workflow with changed trigger results: 29634.911
is this related to this PR or something else? |
@srimanob could you have a look at this result above? it seems to be from wf 29634.911 which is with the new geometry?
|
Hi @artlbv We know that the Phase-2 DD4hep workflow has an issue of initialization, and we are tryting to understand it. I would propose we ignore the dd4hep test result at the moment. We will do heavy test when DD4hep becomes the production. |
good to know, thanks Phat! |
+1 |
PR description:
Adding the Phase-2 SC8 Puppi Jet collection to the L1T event content. The collection was added to the sequence already here: #43233
PR validation:
Not done, but is a trivial change given the collection exists already.
Not a backport, but might do it to 14_0 if still in time for the MC production.