Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SC8 jets to L1T event content #45425

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Add SC8 jets to L1T event content #45425

merged 1 commit into from
Jul 11, 2024

Conversation

artlbv
Copy link
Contributor

@artlbv artlbv commented Jul 10, 2024

PR description:

Adding the Phase-2 SC8 Puppi Jet collection to the L1T event content. The collection was added to the sequence already here: #43233

PR validation:

Not done, but is a trivial change given the collection exists already.

Not a backport, but might do it to 14_0 if still in time for the MC production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @artlbv for master.

It involves the following packages:

  • L1Trigger/Configuration (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d54087/40331/summary.html
COMMIT: fa04853
CMSSW: CMSSW_14_1_X_2024-07-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45425/40331/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2780 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345094
  • DQMHistoTests: Total failures: 922
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 3344148
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@epalencia
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@artlbv
Copy link
Contributor Author

artlbv commented Jul 11, 2024

hm there is one workflow with changed trigger results: 29634.911
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_1_X_2024-07-10-1100+d54087/63537/triggerResults/29634.911_TTbar_14TeV+2026D110_DD4hep/HLT.log

 Events    Accepted      Gained        Lost       Other  Trigger
          10           1          +1           -           -  pDoubleIsoTkPho22_12
          10           1           -          -1           -  pDoublePuppiJet160_35_mass620
          10           6           -          -1           -  pDoublePuppiTau52_52
          10           4          +1           -           -  pIsoTkEleEGEle22_12
          10           5          +1           -           -  pPuppiHT400
          10           3          +1           -           -  L1T_SinglePFPuppiJet230off
          10           4           -          -1           -  L1T_PFPuppiHT450off
          10           6           -          -1           -  L1T_PFHT400PT30_QuadPFPuppiJet_70_55_40_40_2p4
...
          10           1          +1           -           -  HLT_DoublePFPuppiJets128_DoublePFPuppiBTagDeepFlavour_2p4
          10           1          +1           -           -  L1T_TkIsoEm22TkIsoEm12
          10           4          +1           -           -  L1T_TkIsoEle22TkEm12

is this related to this PR or something else?

@artlbv
Copy link
Contributor Author

artlbv commented Jul 11, 2024

@srimanob could you have a look at this result above? it seems to be from wf 29634.911 which is with the new geometry?

 29634.911,  # TTbar_14TeV_TuneCP5                   phase2_realistic_T33        DD4hepExtended2026D110   DD4Hep (HLLHC14TeV BeamSpot) 

29634.911, # TTbar_14TeV_TuneCP5 phase2_realistic_T33 DD4hepExtended2026D110 DD4Hep (HLLHC14TeV BeamSpot)

@srimanob
Copy link
Contributor

Hi @artlbv

We know that the Phase-2 DD4hep workflow has an issue of initialization, and we are tryting to understand it. I would propose we ignore the dd4hep test result at the moment. We will do heavy test when DD4hep becomes the production.

@artlbv
Copy link
Contributor Author

artlbv commented Jul 11, 2024

good to know, thanks Phat!

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c103a34 into cms-sw:master Jul 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants