Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Millepede to V04-14-00 #8953

Merged

Conversation

consuegs
Copy link
Contributor

@consuegs consuegs commented Jan 18, 2024

  • Update of Millepede software version for tracker alignment calibration

  • Introduction of Intel oneMKL PARDISO solution method. PARDISO is to become from now on the solution method of choice for (special) problems with really sparse global matrices

  • See presentation here at TrkAl meeting (09.01.2024) by C. Kleinwort with overview of method and performance summary from test campaign

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @consuegs for branch IB/CMSSW_14_0_X/master.

@cmsbuild, @aandvalenzuela, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 18, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor

cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b707f3/36919/summary.html
COMMIT: e38051d
CMSSW: CMSSW_14_0_X_2024-01-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8953/36919/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar
Copy link
Contributor

assign alca

@cms-sw/alca-l2 , can you please review this?

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@saumyaphor4252,@perrotta,@consuegs you have been requested to review this Pull request/Issue and eventually sign? Thanks

@mmusich
Copy link

mmusich commented Jan 19, 2024

I am a bit puzzled by some of the unit tests outputs.
e.g.:

  • testPedeCampaign seems to have run correctly, but then the last mv fails (due to permission denied). In IBs as far as I can see instead there is no such issue.
  • testPayloadSanity consequently fails due to missing input, but despite it should track the runtime cmsRun failure [1], the test is still declared as succeeded.

[1] https://github.com/cms-sw/cmssw/blob/87aa86684413a8056be46ed8bc1377e4c9954d66/Alignment/MillePedeAlignmentAlgorithm/test/test_payload_sanity.sh#L5

@mmusich
Copy link

mmusich commented Jan 19, 2024

consequently fails due to missing input, but despite it should track the runtime cmsRun failure [1], the test is still declared as succeeded.

OK, this is due to a bug in the script, see fix at cms-sw/cmssw#43754.

@mmusich
Copy link

mmusich commented Jan 19, 2024

test parameters:

@mmusich
Copy link

mmusich commented Jan 19, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b707f3/36936/summary.html
COMMIT: e38051d
CMSSW: CMSSW_14_0_X_2024-01-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8953/36936/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testPayloadSanity had ERRORS

Comparison Summary

Summary:

@mmusich
Copy link

mmusich commented Jan 19, 2024

@cmsbuild, please test

  • now it should succeed

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b707f3/36943/summary.html
COMMIT: e38051d
CMSSW: CMSSW_14_0_X_2024-01-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8953/36943/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b707f3/36943/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b707f3/36943/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3262299
  • DQMHistoTests: Total failures: 2110
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3260167
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 37.96199999999999 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 1.406 KiB Tracking/ShortTrackResolution
  • Checked 211 log files, 163 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • Thank you @mmusich for the fixes in the unit tests

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#43754

@smuzaffar
Copy link
Contributor

As cms-sw/cmssw#43754 has been merged so this is good to go in 14.0.X now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants