Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeV jet RAW-RECO skim #43581

Merged
merged 1 commit into from
Jan 19, 2024
Merged

TeV jet RAW-RECO skim #43581

merged 1 commit into from
Jan 19, 2024

Conversation

lathomas
Copy link
Contributor

PR description:

This PR introduces a new skim selecting events based on the presence of a TeV AK4 PF jet. The main purpose is to be able to quickly react to any anomaly observed with TeV jets (recent example: prefiring, but the scope is larger)
The skim passing rate is found to be 0.1%, i.e an order of magnitude lower than the existing EXOHighMET skim
The proposal is presented in these slides shown at a PPD meeting.

PR validation:

The following command runs locally

 cmsDriver.py SKIM --filein /store/data/Run2023D/JetMET1/RAW/v1/000/370/340/00000/e82d9e40-ebb8-4311-a083-0a248a220d87.root --fileout file:SKIM_TeVJet.root --nThreads 8 --no_exec --number 100 --python_filename SKIM_TeVJet.py --scenario pp --step RAW2DIGI,L1Reco,RECO,SKIM:TeVJet --data --conditions auto:run3_data_prompt --era Run3

However, given the low passing rate of the skim, no event is passing. Running on crab on /JetMET0/Run2023C-v1/RAW works and give passing events with the passing rate quoted above.
The output dataset can be found here

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 15, 2023

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43581/38228

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lathomas for master.

It involves the following packages:

  • DPGAnalysis/Skims (pdmv)

@AdrianoDee, @miquork, @cmsbuild, @sunilUIET can you please review it and eventually sign? Thanks.
@youyingli, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@miquork
Copy link

miquork commented Dec 15, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6be99/36522/summary.html
COMMIT: 7dac0f2
CMSSW: CMSSW_14_0_X_2023-12-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43581/36522/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 89 lines from the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3429858
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3429836
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@youyingli
Copy link
Contributor

Hi @lathomas , just make sure if the skim follows the below PDs:

  • 2022 : JetHT, MET, JetMET
  • 2023 : JetMET

@lathomas
Copy link
Contributor Author

Hi @youyingli somehow I missed your post. Yes, the list of datasets is correct (in 2023, JetMET is splitted in JetMET0 and JetMET1 though).

@youyingli
Copy link
Contributor

Hi @AdrianoDee, could you sign this PR?

@youyingli
Copy link
Contributor

Hi @AdrianoDee, could you sign this PR?

@AdrianoDee , please sign this PR

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a5e0ace into cms-sw:master Jan 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants