Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beginRun/beginLuminosityBlock methods in EGammaElectronProducers #43665

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

This is part of framework change that will require stream modules to explicitly register to use Run/LuminosityBlock transitions.

PR validation:

Code compiles.

- moved EventSetup get to produce
- changed to new framework syntax
- moved EventSetup get to produce method
- fixed member data names to match CMS convention
@Dr15Jones
Copy link
Contributor Author

@makortel FYI

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Jan 5, 2024
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43665/38331

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • L1Trigger/L1TCaloLayer1 (l1)
  • L1Trigger/L1THGCalUtilities (l1, upgrade)
  • L1Trigger/L1TZDC (l1)
  • RecoEgamma/EgammaElectronProducers (reconstruction)

@mandrenguyen, @jfernan2, @aloeliger, @srimanob, @epalencia, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @lgray, @amarini, @varuns23, @Prasant1993, @jbsauvan, @jainshilpi, @sameasy, @ram1123, @valsdav, @a-kapoor, @Sam-Harper, @afiqaize, @rovere, @sobhatta this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8704e/36719/summary.html
COMMIT: 4e1e43c
CMSSW: CMSSW_14_0_X_2024-01-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43665/36719/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3247277
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247255
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@mandrenguyen
Copy link
Contributor

+1

@Dr15Jones
Copy link
Contributor Author

ping @cms-sw/upgrade-l2

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f215008 into cms-sw:master Jan 19, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the cleanupEgammaElectronProducers branch January 19, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants