Cleanup beginRun in L1Trigger

[Dr15Jones]

PR description:

• removed empty beginRun methods
• moved EventSetup get to produce in CaloTruthCellsProducer

This is part of framework change that will require stream modules to explicitly register to use Run/LuminosityBlock transitions.

PR validation:

Code compiles.

[Dr15Jones]

@makortel FYI

[Dr15Jones]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43660/38325

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TCaloLayer1/plugins/L1TCaloSummary.cc modified in PR(s): Cicada pattern testing #43440

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• L1Trigger/L1TCaloLayer1 (l1)
• L1Trigger/L1THGCalUtilities (l1, upgrade)
• L1Trigger/L1TZDC (l1)

@srimanob, @aloeliger, @subirsarkar, @epalencia can you please review it and eventually sign? Thanks.
@lgray, @missirol, @Martin-Grunewald, @amarini, @jbsauvan this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fede16/36713/summary.html
COMMIT: 2a1c203
CMSSW: CMSSW_14_0_X_2024-01-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43660/36713/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 90 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247249
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[Dr15Jones]

ping @cms-sw/upgrade-l2