Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GBL to V03-01-00 #8976

Conversation

henriettepetersen
Copy link

  • Update of GBL software version for tracker alignment calibration
  • Main implementation in the new GBL version is THICK scatterers at GblPoints
  • Works with new MP version in the PR here: Update Millepede to V04-14-00 #8953
  • See presentation here at TrkAl meeting (09.01.2024) by C. Kleinwort with overview of method and performance summary from test campaign.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @henriettepetersen for branch IB/CMSSW_14_0_X/master.

@smuzaffar, @iarspider, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor

please test workflow 1001.0,1001.2,1001.3,1001.5

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-410f55/37108/summary.html
COMMIT: 893a286
CMSSW: CMSSW_14_0_X_2024-01-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8976/37108/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
Requested to quit.
Requested to quit.
* The action "build-external+gbl+V03-01-00-bc8d654b69f8d929525f4f5e41422607" was not completed successfully because Failed to build gbl. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/gbl/V03-01-00-bc8d654b69f8d929525f4f5e41422607/log. Final lines of the log file:
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02822/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-d6bc5640efdc17abf386d018e8c9ca0d/include/eigen3/Eigen/src/Core/arch/SSE/MathFunctions.h:69:20:   required from here
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02822/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-d6bc5640efdc17abf386d018e8c9ca0d/include/eigen3/Eigen/src/Core/MathFunctions.h:1362:100: error: no matching function for call to 'isfinite_impl(const float&)'
1362 | template EIGEN_DEVICE_FUNC bool (isfinite)(const T &x) { return internal::isfinite_impl(x); }
|                                                                             ~~~~~~~~~~~~~~~~~~~~~~~^~~
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02822/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-d6bc5640efdc17abf386d018e8c9ca0d/include/eigen3/Eigen/src/Core/MathFunctions.h:1836:24: note: candidate: 'template bool Eigen::internal::isfinite_impl(const std::complex<_Tp>&)'
1836 | EIGEN_DEVICE_FUNC bool isfinite_impl(const std::complex& x)
|                        ^~~~~~~~~~~~~


@mmusich
Copy link

mmusich commented Jan 30, 2024

-1

I suppose we need to bump up eigen as well?

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_14_0_X/master to IB/CMSSW_14_1_X/master February 6, 2024 10:21
@mmusich
Copy link

mmusich commented Mar 5, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-410f55/37900/summary.html
COMMIT: 893a286
CMSSW: CMSSW_14_1_X_2024-03-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8976/37900/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

FATAL: malformed spec found while quering it. Command: 
source /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/rpm-env.sh ;  rpm -q --specfile /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/tmpspec-gbl --info --define "cmsdist_directory /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cmsdist" --define "compilerv 1231" --define "cmscompilerv 12" --define "cmsos el8_amd64" --define "almalinux_ver 8" --define "almalinux 8" --define "centos_ver 8" --define "centos 8" --define "rhel 8" --define "dist .el8" --define "el8 1" --define "package_vectorization %{nil}" --define "cmsswdata_version_link 1"  --define 'buildroot /foo'
Resulted in:

warning: line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+gbl+V03-01-00-b8bf684db4b8a6b033bdcec70ce18f83
error: line 369: Unknown tag: <<<<<<< HEAD
error: query of specfile /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/tmpspec-gbl failed, can't parse
Traceback (most recent call last):
  File "./pkgtools/cmsBuild", line 4777, in 
    build(opts, args[1:], PKGFactory)
  File "./pkgtools/cmsBuild", line 3984, in build


@iarspider
Copy link
Contributor

@henriettepetersen please resolve conflicts

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

Pull request #8976 was updated.

@sroychow
Copy link
Contributor

sroychow commented Mar 5, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-410f55/37911/summary.html
COMMIT: d87b019
CMSSW: CMSSW_14_1_X_2024-03-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8976/37911/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

make[2]: *** [CMakeFiles/GBL.dir/build.make:135: CMakeFiles/GBL.dir/src/GblTrajectory.cpp.o] Error 1
make[2]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/gbl/V03-01-00-8031832b2778601c3945440ab1041c5d/gbl-V03-01-00/build'
make[1]: *** [CMakeFiles/Makefile2:888: CMakeFiles/GBL.dir/all] Error 2
make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/gbl/V03-01-00-8031832b2778601c3945440ab1041c5d/gbl-V03-01-00/build'
make: *** [Makefile:149: all] Error 2
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Ltdio7 (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+gbl+V03-01-00-8031832b2778601c3945440ab1041c5d
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Ltdio7 (%build)


@iarspider
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-410f55/37922/summary.html
COMMIT: d87b019
CMSSW: CMSSW_14_1_X_2024-03-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8976/37922/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

make[2]: *** [CMakeFiles/GBL.dir/build.make:135: CMakeFiles/GBL.dir/src/GblTrajectory.cpp.o] Error 1
make[2]: Leaving directory '/pool/condor/dir_3756739/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/gbl/V03-01-00-8031832b2778601c3945440ab1041c5d/gbl-V03-01-00/build'
make[1]: *** [CMakeFiles/Makefile2:888: CMakeFiles/GBL.dir/all] Error 2
make[1]: Leaving directory '/pool/condor/dir_3756739/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/gbl/V03-01-00-8031832b2778601c3945440ab1041c5d/gbl-V03-01-00/build'
make: *** [Makefile:149: all] Error 2
error: Bad exit status from /pool/condor/dir_3756739/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.0LIN70 (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+gbl+V03-01-00-8031832b2778601c3945440ab1041c5d
Bad exit status from /pool/condor/dir_3756739/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.0LIN70 (%build)


@mmusich
Copy link

mmusich commented Mar 6, 2024

@iarspider do you have any insight on the cause of the errors above?

@mmusich
Copy link

mmusich commented Mar 6, 2024

this is supposedly superseded by #9053 (hopefully that one won't have compilation errors).

@smuzaffar
Copy link
Contributor

closing it as a new version of gbl has already been integrated via #9053

@smuzaffar smuzaffar closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants