Add Run3 promptData JetID #43195

etzia · 2023-11-06T09:46:50Z

PR description:

The JetID criteria for the prompt reco 2022 and 2023 data have been implemented.
The criteria can be found in
https://twiki.cern.ch/twiki/bin/view/CMS/JetID13p6TeV

PR validation:

I have run successfully the following checks:
scram b code-checks
scram b code-format

cmsbuild · 2023-11-06T09:53:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43195/37514

This PR adds an extra 24KB to repository

cmsbuild · 2023-11-06T09:53:31Z

A new Pull Request was created by @etzia (Eirini Tziaferi) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)
PhysicsTools/SelectorUtils (reconstruction)

@jfernan2, @mandrenguyen, @vlimant, @cmsbuild, @simonepigazzini can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2023-11-06T16:51:58Z

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

jfernan2 · 2023-11-06T18:19:34Z

please test

cmsbuild · 2023-11-06T20:52:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58eb2b/35644/summary.html
COMMIT: 1f7df1d
CMSSW: CMSSW_13_3_X_2023-11-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43195/35644/install.sh to create a dev area with all the needed externals and cmssw changes.

Found compilation warnings

Comparison Summary

Summary:

You potentially removed 98 lines from the logs
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3363010
DQMHistoTests: Total failures: 687
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3362301
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

jfernan2 · 2023-11-07T08:38:41Z

@etzia there are compilation warnings https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58eb2b/35644/summary.html

simonepigazzini · 2023-11-08T08:38:28Z

enable nano

simonepigazzini · 2023-11-08T08:38:32Z

please test

cmsbuild · 2024-01-16T09:27:30Z

Pull request #43195 was updated. @cmsbuild, @vlimant, @jfernan2, @hqucms, @mandrenguyen can you please check and sign again.

jfernan2 · 2024-01-16T11:19:27Z

please test

cmsbuild · 2024-01-16T13:53:25Z

-1

Failed Tests: RelVals RelVals-INPUT RelVals-NANO
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58eb2b/36842/summary.html
COMMIT: d4e03ce
CMSSW: CMSSW_14_0_X_2024-01-15-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43195/36842/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

136.8311

----- Begin Fatal Exception 16-Jan-2024 12:42:56 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/ElectronIdentification/data/MVAWeightFiles/Winter22HZZV1/EB1_5.weights.xml.gz anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43195/36842/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43195/36842/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43195/36842/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.8311_RunJetHT2017FreMINIAOD
----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 16-Jan-2024 12:42:56 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/ElectronIdentification/data/MVAWeightFiles/Winter22HZZV1/EB1_5.weights.xml.gz anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43195/36842/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43195/36842/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43195/36842/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.7611_RunJetHT2016EreMINIAOD
----- End Fatal Exception -------------------------------------------------

136.88811

----- Begin Fatal Exception 16-Jan-2024 12:42:57 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/ElectronIdentification/data/MVAWeightFiles/Winter22HZZV1/EB1_5.weights.xml.gz anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43195/36842/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43195/36842/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43195/36842/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.88811_RunJetHT2018DreMINIAODUL
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
136.72411136.72411_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
136.72412136.72412_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log

Expand to see more relval errors ...

RelVals-NANO

2500.32500.3_NANOmc130X/step2_NANOmc130X.log
2500.0012500.001_NANOmc106Xul17v2/step2_NANOmc106Xul17v2.log
2500.02500.0_NANOmc106Xul16v2/step2_NANOmc106Xul16v2.log

Expand to see more relval errors ...

vlimant · 2024-01-17T07:43:36Z

failures independent of the PR. something else is broken apparently

vlimant · 2024-01-17T07:47:56Z

please test

mandrenguyen · 2024-01-17T08:35:14Z

failures independent of the PR. something else is broken apparently

The failure was due to this: cms-data/RecoEgamma-ElectronIdentification#28 (comment)
but it should be fixed now in the latest IB

cmsbuild · 2024-01-17T10:48:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58eb2b/36878/summary.html
COMMIT: d4e03ce
CMSSW: CMSSW_14_0_X_2024-01-16-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43195/36878/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 22 lines to the logs
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3247526
DQMHistoTests: Total failures: 901
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3246603
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16489
DQMHistoTests: Total failures: 34
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16455
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.544	2.544	0.000 ( +0.0% )	5.31	5.21	+1.8%	2.230	2.170
2500.001	2.691	2.691	-0.000 ( -0.0% )	4.75	4.74	+0.1%	2.665	2.589
2500.002	2.629	2.629	-0.000 ( -0.0% )	4.91	4.87	+0.8%	2.633	2.582
2500.01	1.314	1.314	0.000 ( +0.0% )	9.81	9.35	+4.8%	2.306	2.273
2500.011	1.730	1.730	-0.000 ( -0.0% )	5.17	5.18	-0.2%	2.518	2.423
2500.012	1.576	1.576	-0.000 ( -0.0% )	7.55	7.39	+2.1%	2.444	2.334
2500.1	2.192	2.192	-0.000 ( -0.0% )	5.31	5.29	+0.5%	2.063	2.060
2500.2	2.307	2.307	0.000 ( +0.0% )	6.09	6.11	-0.3%	1.978	1.969
2500.21	1.182	1.182	0.000 ( +0.0% )	4.34	4.33	+0.1%	2.260	2.256
2500.211	1.545	1.545	0.000 ( +0.0% )	3.83	3.81	+0.6%	2.347	2.333
2500.3	2.062	2.062	0.000 ( +0.0% )	12.72	12.54	+1.4%	1.967	1.851
2500.31	1.257	1.257	0.000 ( +0.0% )	20.10	20.19	-0.5%	2.356	2.321
2500.311	1.645	1.645	0.000 ( +0.0% )	13.81	13.73	+0.6%	2.418	2.410
2500.312	7.025	7.025	0.000 ( +0.0% )	1.43	1.41	+1.5%	1.690	1.605
2500.313	1.471	1.471	0.000 ( +0.0% )	7.05	7.03	+0.2%	1.047	0.940
2500.4	2.062	2.062	0.000 ( +0.0% )	12.63	12.69	-0.5%	1.965	1.924
2500.5	19.575	19.575	0.000 ( +0.0% )	1.21	1.21	-0.2%	1.354	1.131

vlimant · 2024-01-17T14:15:42Z

+1

jfernan2 · 2024-01-17T15:34:35Z

+1

cmsbuild · 2024-01-17T15:35:00Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-01-19T16:00:17Z

+1

Add Run3 promptData JetID

1f7df1d

cmsbuild added this to the CMSSW_13_3_X milestone Nov 6, 2023

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Nov 6, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 6, 2023

smuzaffar modified the milestones: CMSSW_13_3_X, CMSSW_14_0_X Nov 6, 2023

cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_13_3_X Nov 6, 2023

cmsbuild modified the milestones: CMSSW_13_3_X, CMSSW_14_0_X Nov 6, 2023

cmsbuild added tests-started and removed tests-pending labels Nov 6, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 6, 2023

cmsbuild added tests-started and removed tests-approved labels Nov 8, 2023

cmsbuild added the code-checks-approved label Jan 16, 2024

cmsbuild added tests-started and removed tests-pending labels Jan 16, 2024

cmsbuild added tests-rejected and removed tests-started labels Jan 16, 2024

cmsbuild added tests-started and removed tests-rejected labels Jan 17, 2024

cmsbuild added tests-approved and removed tests-started labels Jan 17, 2024

cmsbuild added xpog-approved and removed xpog-pending labels Jan 17, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Jan 17, 2024

cmsbuild added orp-approved and removed orp-pending labels Jan 19, 2024

cmsbuild merged commit 2c285f2 into cms-sw:master Jan 19, 2024
13 checks passed

cmsbuild mentioned this pull request Jan 20, 2024

Update Millepede to V04-14-00 cms-sw/cmsdist#8953

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Run3 promptData JetID #43195

Add Run3 promptData JetID #43195

etzia commented Nov 6, 2023

cmsbuild commented Nov 6, 2023

cmsbuild commented Nov 6, 2023 •

edited

Loading

smuzaffar commented Nov 6, 2023

jfernan2 commented Nov 6, 2023

cmsbuild commented Nov 6, 2023

jfernan2 commented Nov 7, 2023

simonepigazzini commented Nov 8, 2023

simonepigazzini commented Nov 8, 2023

cmsbuild commented Jan 16, 2024

jfernan2 commented Jan 16, 2024

cmsbuild commented Jan 16, 2024

vlimant commented Jan 17, 2024

vlimant commented Jan 17, 2024

mandrenguyen commented Jan 17, 2024

cmsbuild commented Jan 17, 2024

vlimant commented Jan 17, 2024

jfernan2 commented Jan 17, 2024

cmsbuild commented Jan 17, 2024

rappoccio commented Jan 19, 2024

Add Run3 promptData JetID #43195

Add Run3 promptData JetID #43195

Conversation

etzia commented Nov 6, 2023

PR description:

PR validation:

cmsbuild commented Nov 6, 2023

cmsbuild commented Nov 6, 2023 • edited Loading

smuzaffar commented Nov 6, 2023

jfernan2 commented Nov 6, 2023

cmsbuild commented Nov 6, 2023

Comparison Summary

jfernan2 commented Nov 7, 2023

simonepigazzini commented Nov 8, 2023

simonepigazzini commented Nov 8, 2023

cmsbuild commented Jan 16, 2024

jfernan2 commented Jan 16, 2024

cmsbuild commented Jan 16, 2024

RelVals

RelVals-INPUT

RelVals-NANO

vlimant commented Jan 17, 2024

vlimant commented Jan 17, 2024

mandrenguyen commented Jan 17, 2024

cmsbuild commented Jan 17, 2024

Comparison Summary

NANO Comparison Summary

vlimant commented Jan 17, 2024

jfernan2 commented Jan 17, 2024

cmsbuild commented Jan 17, 2024

rappoccio commented Jan 19, 2024

cmsbuild commented Nov 6, 2023 •

edited

Loading