[GCC] Update to GCC 12.3.1 #8526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test parameters:
|
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_2_X/g12. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
|
please test for el8_amd64_gcc12 |
|
ICE! |
|
I reproduced in my area. |
|
this one gives me "no match" |
|
got it! the culprit seems to be |
|
minimal nvcc -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02786/el8_amd64_gcc12/external/eigen/82dd3710dac619448f50331c1d6a35da673f764a-a265c39c534705ccfbcfdf86bff919ba/include/eigen3 simpleCholeskyTest.cu --expt-relaxed-constexpr -std=c++17 -O3 --source-in-ptx -x cu -dc |
|
self contained test in https://github.com/VinInn/ctest/tree/master/cuda/ice |
|
for reference |
|
@fwyzard FYI |
|
hi @VinInn, we already reported to NVIDIA a problem caused by NVIDIA support confirmed that it is a known issue, that they have an internal fix, and that it should be fixed in the next CUDA minor version (not sure if they mean 12.1.2 or 12.2.0). Can you confirm that the same test can be compiled with 12.0.x ? |
|
@fwyzard where I can find a cuda 12.0.x? |
|
in order to move on we could remove |
/cvmfs/patatrack.cern.ch/externals/x86_64/rhel8/nvidia/cuda-12.0.1/ |
|
/cvmfs/patatrack.cern.ch/externals/x86_64/rhel8/nvidia/cuda-12.0.1/bin/nvcc -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02786/el8_amd64_gcc12/external/eigen/82dd3710dac619448f50331c1d6a35da673f764a-a265c39c534705ccfbcfdf86bff919ba/include/eigen3 simpleCholeskyTest.cu --expt-relaxed-constexpr -std=c++17 -O3 --source-in-ptx -x cu -dc no error |
|
please test with #8527 for el8_amd64_gcc12 |
|
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: Entering library rule at RecoTBCalo/HcalTBTools >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/RecoTBCalo/HcalTBTools/src/HcalTBTriggerFilter.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/RecoTBCalo/HcalTBTools/src/SealModule.cc >> Building edm plugin tmp/el8_amd64_gcc12/src/RecoTBCalo/HcalTBTools/src/RecoTBCaloHcalTBTools/libRecoTBCaloHcalTBTools.so /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-e30fb68be5dbc9ad534ab5b10ba8ea7c/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lTBDataFormatsHcalTBObjects collect2: error: ld returned 1 exit status gmake: *** [tmp/el8_amd64_gcc12/src/RecoTBCalo/HcalTBTools/src/RecoTBCaloHcalTBTools/libRecoTBCaloHcalTBTools.so] Error 1 Leaving library rule at RecoTBCalo/HcalTBTools >> Leaving Package RecoTBCalo/HcalTBTools >> Package RecoTBCalo/HcalTBTools built >> Entering Package SimTracker/TrackerFilters |
|
please test for el8_amd64_gcc12 |
cmsbuild
added
tests-started
tests-rejected
and removed
requires-external
tests-rejected
tests-started
labels
|
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HFNoseRawToDigiFake.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigi.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigiFake.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HGCalSlinkEmulator.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigi.cc: In member function 'virtual void HGCalRawToDigi::produce(edm::Event&, const edm::EventSetup&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigi.cc:68:37: error: comparing the result of pointer addition '(ptr + ((sizetype)i))' and NULL [-Werror=address]
68 | data_32bit.emplace_back(((ptr + i) ? ((*(ptr + i) & 0xff) << 0) : 0) +
| ~~~~~^~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigi.cc:69:41: error: comparing the result of pointer addition '(ptr + (((sizetype)i) + 1))' and NULL [-Werror=address]
69 | ((ptr + i + 1) ? ((*(ptr + i + 1) & 0xff) << 8) : 0) +
| ~~~~~~~~~^~~~
|
|
this looks good. we have the same errors as we have with GCC 12.2.1, so lets get this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.