-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ExtVec for clang #41744
fix ExtVec for clang #41744
Conversation
fixes #41707 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41744/35607
|
A new Pull Request was created by @VinInn (Vincenzo Innocente) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5159f/32736/summary.html Comparison SummarySummary:
|
please test for CMSSW_13_2_CLANG_X |
please test use latest IB for default PR tests |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5159f/32745/summary.html Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5159f/32744/summary.html Comparison SummarySummary:
|
Is it expected that the reco comparison tests shows so many differences (even if they look quite small)? |
try the clang build on a different "technical" PR |
you can see the baseline is a gcc build, so seems normal to me. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The length of the vector was wrong for clang.
clang support GCC vector extension syntax: no reason to use OpenCL one.
The effect is only visible in explicit tests and for clang build on ARM or Power
(I expect some workflow should have failed)