-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate DiMuonMassBiasClient
mass bias histograms to profiles
#41779
Migrate DiMuonMassBiasClient
mass bias histograms to profiles
#41779
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41779/35653
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e22149/32821/summary.html Comparison SummarySummary:
|
I was trying to track down where the extra log lines came from given you just moved and duplicated the edm::LogPrint for the TH1 and TProfile cases so I would not expect any difference... Probably just spurious. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The main goal of this PR is to migrate the underlying ROOT type of the di-muon mass bias ME produced by
DiMuonMassBiasClient
from beingTH1
-s toTProfile
-s. This would solve the visualization issues when displaying these in the GUI overlaid with a previous run.I leave the possibility to produce histograms instead via a dedicated configuration flag, since that might be useful when run in standalone mode. Additionally I restrict the range of the μμ pair Δη for the Z→μμ case.
PR validation:
I've run successfully the unit tests of this packages via
scram b runtests_testDiMuonVertexMonitor use-ibeos
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but a backport to the data-taking release will be needed.