"SCALLumi" histos renamed as "OnlineLumi"

[acmbulla]

PR description:

Minimal changes. Changed the name of some histograms (and variables) that reported erroneously the nomenclature "SCAL", which is no longer used. "Online" is used instead.

PR validation:

Run the matrix to test the correctness of the names, Everything went good.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41220/34937

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @acmbulla (Andrea Bulla) for master.

It involves the following packages:

• DQM/TrackingMonitor (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@arossi83, @VourMa, @hdelanno, @sroychow, @JanFSchulte, @VinInn, @fioriNTU, @jandrea, @mtosi, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-007653/31678/summary.html
COMMIT: b9cc02d
CMSSW: CMSSW_13_1_X_2023-03-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41220/31678/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 29 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3541142
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3541114
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 25.57399999999999 KiB( 48 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 0.641 KiB Tracking/TrackParameters
• DQMHistoSizes: changed ( 1000.0,... ): 0.320 KiB Muons/globalMuons
• DQMHistoSizes: changed ( 1000.0,... ): 0.211 KiB AlCaReco/SiStripCalMinBias
• DQMHistoSizes: changed ( 1000.0 ): 0.211 KiB AlCaReco/TkAlCosmicsInCollisions
• DQMHistoSizes: changed ( 1000.0 ): 0.211 KiB AlCaReco/TkAlJetHT
• DQMHistoSizes: changed ( 1000.0 ): 0.211 KiB AlCaReco/TkAlJpsiMuMu
• DQMHistoSizes: changed ( 1000.0,... ): 0.211 KiB AlCaReco/TkAlMinBias
• DQMHistoSizes: changed ( 1000.0 ): 0.211 KiB AlCaReco/TkAlMuonIsolated
• DQMHistoSizes: changed ( 1000.0 ): 0.211 KiB AlCaReco/TkAlUpsilonMuMu
• DQMHistoSizes: changed ( 1000.0 ): 0.211 KiB AlCaReco/TkAlZMuMu
• DQMHistoSizes: changed ( 10024.0 ): ...
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

Just out of curiosity, how is this changing DQMHistoSizes? Can it be just the change in the labels?

[mmusich]

how is this changing DQMHistoSizes? Can it be just the change in the labels?

Good question, I was also not expecting it. Curiously it seems concentrated on workflow 1000.0. OTOH the bin-by-bin comparison shows only replacements (or spurious differences). How to reconcile the two?

[emanueleusai]

+1

• approving, as the change in size of the histos is not a showstopper

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

hold

• I guess would be good to understand "SCALLumi" histos renamed as "OnlineLumi" #41220 (comment) before merging

[cmsbuild]

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[mmusich]

@cmsbuild, please test

• let's see if it reproduces

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-007653/32758/summary.html
COMMIT: b9cc02d
CMSSW: CMSSW_13_2_X_2023-05-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41220/32758/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially removed 15 lines from the logs
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3209363
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3209329
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 23.881999999999994 KiB( 47 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 0.641 KiB Tracking/TrackParameters
• DQMHistoSizes: changed ( 1000.0,... ): 0.320 KiB Muons/globalMuons
• DQMHistoSizes: changed ( 1000.0,... ): 0.211 KiB AlCaReco/SiStripCalMinBias
• DQMHistoSizes: changed ( 1000.0 ): 0.211 KiB AlCaReco/TkAlCosmicsInCollisions
• DQMHistoSizes: changed ( 1000.0 ): 0.211 KiB AlCaReco/TkAlJetHT
• DQMHistoSizes: changed ( 1000.0 ): 0.211 KiB AlCaReco/TkAlJpsiMuMu
• DQMHistoSizes: changed ( 1000.0,... ): 0.211 KiB AlCaReco/TkAlMinBias
• DQMHistoSizes: changed ( 1000.0 ): 0.211 KiB AlCaReco/TkAlMuonIsolated
• DQMHistoSizes: changed ( 1000.0 ): 0.211 KiB AlCaReco/TkAlUpsilonMuMu
• DQMHistoSizes: changed ( 1000.0 ): 0.211 KiB AlCaReco/TkAlZMuMu
• DQMHistoSizes: changed ( 10024.0 ): ...
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

unhold

• private checks on the files produced in the PR tests by @acmbulla underline that the apparent changes at "SCALLumi" histos renamed as "OnlineLumi" #41220 (comment) are spurious (e.g. there is no removal of histograms, just renaming). This might be a symptom of a bug in the comparison script

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge