Run3-alca142 Modify the datastream for HcalIsolatedBunchSelector

[bsunanda]

PR description:

Modify the datastream for HcalIsolatedBunchSelector

PR validation:

Add HcalIsolatedBunchSelector AlCaReco to the Commissioning data stream

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

May be needed to backport this to 13_0_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41510/35384

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Configuration/AlCa (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[tvami]

@bsunanda @mariadalfonso I think this is not what we agreed last time. Last time we agreed that HcalCalIsolatedBunchFilter and HcalCalIsolatedBunchSelector do the same thing except for the trigger bit handling. Then we all agreed that the trigger bit handling does not need a new ALCARECO, it can be just done by the GT. And then we agreed that there is no need for two ALCARECOs that do the same. I think we even agreed that one of them will be removed from CMSSW, and they will be named better.

[tvami]

@cmsbuild , please abort

• the wf that runs the alcareco mtx was not set

[bsunanda]

@tvami We can remove HcalCalIsolatedBunchFilter from the matrix to be used. Can HcalCalIsolatedBunchSelector stay unchanged? We can make these changes now.

[tvami]

@bsunanda I didnt mean to remove it just from the matrix, but completely remove it from CMSSW. It is a dupplicate after all...

[bsunanda]

@tvami I have removed the IsolatedBunchFilter from all Configuration packages. Which is the wf that runs the AlCaReco matrix which needs to be set?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41510/35440

• This PR adds an extra 24KB to repository

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-698ea0/32434/summary.html
COMMIT: 2c4cca8
CMSSW: CMSSW_13_2_X_2023-05-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41510/32434/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 28 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460836
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3460810
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.016 KiB( 47 files compared)
• DQMHistoSizes: changed ( 1000.0 ): -0.008 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 1000.0 ): -0.008 KiB MessageLogger/Warnings
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tvami]

But this PR is to be integrated first.

There must be a misunderstanding here. This PR is not relevant for data taking, the AlCaRECO matrix dict is only used in the rereco, i.e. not urgent until October. T0 has HcalCalIsolatedBunchFilter attached to the Commissioning PD, as it was earlier requested from HCAL. If you want HcalCalIsolatedBunchSelector to be attached to the Commissioning PD, you need to ask the T0 friends to do that, here https://cms-talk.web.cern.ch/c/offcomp/compops/tier0/210

FYI @mariadalfonso (I feel like we are going back and forth between these HCAL isobunch ALCARECOs -- but given that they are supposed to do the same thing, maybe it doesnt matter...)

[bsunanda]

@tvami Please approve this PR. I cannot make a separate PR to remove the duplicate code unless this PR is merged.

[tvami]

@bsunanda I'm sorry by why couldn't you? Also, as I've been trying to say for a month now, this PR is not relevant for data taking, see #41510 (comment)

[tvami]

I'm sorry by why couldn't you?

I mean, just make other commits to this PR.

[bsunanda]

@tvami I have one more branch ready to be submitted - just waiting for this PR to be merged

[tvami]

+alca

• see Run3-alca142 Modify the datastream for HcalIsolatedBunchSelector #41510 (comment)

[bsunanda]

@perrotta Could you please merge this now?

[perrotta]

@cmsbuild please test workflow 1001.2,1001.3,1002.3,1002.4

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-698ea0/32839/summary.html
COMMIT: 2c4cca8
CMSSW: CMSSW_13_2_X_2023-05-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41510/32839/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 39 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3353687
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3353661
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.032 KiB( 51 files compared)
• DQMHistoSizes: changed ( 1002.4,... ): -0.008 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 1002.4,... ): -0.008 KiB MessageLogger/Warnings
• Checked 225 log files, 163 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.