Undefine _Float16 #41819
Merged
Undefine _Float16 #41819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent _Float16 defined by CUDA headers from hiding the ISO C type used by GCC
|
enable gpu |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41819/35710
|
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
@mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test for el8_amd64_gcc12 |
|
-1 Failed Tests: Build HeaderConsistency The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HFNoseRawToDigiFake.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigi.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigiFake.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HGCalSlinkEmulator.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigi.cc: In member function 'virtual void HGCalRawToDigi::produce(edm::Event&, const edm::EventSetup&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigi.cc:68:37: error: comparing the result of pointer addition '(ptr + ((sizetype)i))' and NULL [-Werror=address]
68 | data_32bit.emplace_back(((ptr + i) ? ((*(ptr + i) & 0xff) << 0) : 0) +
| ~~~~~^~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-29-1100/src/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigi.cc:69:41: error: comparing the result of pointer addition '(ptr + (((sizetype)i) + 1))' and NULL [-Werror=address]
69 | ((ptr + i + 1) ? ((*(ptr + i + 1) & 0xff) << 8) : 0) +
| ~~~~~~~~~^~~~
|
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e774b/32884/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
|
please test with #41792 for el8_amd64_gcc12 |
|
-1 Failed Tests: HeaderConsistency UnitTests RelVals AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test DiMuonVertex had ERRORS ---> test PrimaryVertex had ERRORS ---> test test_DetectorStateFilter had ERRORS ---> test Miscellanea had ERRORS and more ... RelValsExpand to see more relval errors ...
AddOn TestsExpand to see more addon errors ...
|
|
please test for el8_aarch64_gcc11 |
|
please test for el8_ppc64le_gcc11 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e774b/32914/summary.html |
|
Hi @smuzaffar , which test results should I consider? |
|
@clacaputo , you should consider the production architecture results which are #41819 (comment) . Also This PR is to fix the build errors of gcc12, so you should also look the results of el8_amd64_gcc12 i.e. #41819 (comment) . gcc12 IBs are broken so this P is not going to fix every thing for gcc12 but at least the built errors are fixed ( as expacted) https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e774b/32895/build-logs/ |
|
+reconstruction |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
reconstruction-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
Update: the underlying problem has been fixed in CUDA 12.2.2 (see nvidia_bug_4139266). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
CUDA headers define
_Float16to the CUDA__halftype. This conflicts with the ISO C type used for 16-bit floating point numbers, that is supported by GCC 12 for SSE2 and later instruction sets.Prevent _Float16 defined by CUDA headers from hiding the ISO C type used by GCC.
PR validation:
None.