Add stopSession() and resumeSession() to Client #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to stop and resume sessions. This prevents the handled/unhandled error count from incrementing when a session is in the stopped state, which may be desirable if a user manually tracks sessions and does not care about crashes that occur in the background.
fractalwrench
commented
Feb 13, 2019
| @@ -65,7 +66,9 @@ | |||
| * @param date the session start date | |||
| * @param user the session user (if any) | |||
| */ | |||
| @Nullable Session startNewSession(@NonNull Date date, @Nullable User user, | |||
| @Nullable | |||
| @VisibleForTesting | |||
There was a problem hiding this comment.
This documents that the method has been left package-visible for existing unit tests, and would otherwise be private.
when a session is stopped, no session information should be present in error payloads.
This was referenced Feb 13, 2019
…ssion information in their payl
Allow sessions to be stopped on the NDK. when a session is stopped from the java layer, the session information will no longer be serialised in the error payload of fatal NDK errors.
Pezzah
reviewed
Feb 15, 2019
Pezzah
reviewed
Feb 15, 2019
the START_SESSION message is emitted when a session is started or resumed, and allows the NDK layer to update its cached value for session information which is included in the error payload. It was previously assumed that the handled count would always be 0 when starting a session - this is no longer the case as sessions can be resumed, therefore the handled count is passed as part of the message.
Support stopSession() and resumeSession() in NDK
Pezzah
reviewed
Feb 19, 2019
Pezzah
approved these changes
Feb 19, 2019
Add mazerunner scenarios for stopping/resuming a session
Wait for session scenarios to send session before crashing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds the ability to stop and resume sessions. This prevents the handled/unhandled error count from incrementing when a session is in the stopped state, which may be desirable if a user manually tracks sessions and does not care about crashes that occur in the background.
Changeset
Added the public interface for stopping/resuming a session, along with the initial implementation, unit test coverage, and docs.
NOTE: NDK support was added in #432 and mazerunner scenarios have been added in #430.