Support stopSession() and resumeSession() in NDK #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssion information in their payl
Allow sessions to be stopped on the NDK. when a session is stopped from the java layer, the session information will no longer be serialised in the error payload of fatal NDK errors.
the START_SESSION message is emitted when a session is started or resumed, and allows the NDK layer to update its cached value for session information which is included in the error payload. It was previously assumed that the handled count would always be 0 when starting a session - this is no longer the case as sessions can be resumed, therefore the handled count is passed as part of the message.
fractalwrench
force-pushed
the
stop-sessions-ndk
branch
from
e07c7fa to
3fd8417
Compare
kattrali
suggested changes
Feb 18, 2019
| } | ||
|
|
||
| void stopSession() { | ||
| Session session = currentSession.get(); | ||
|
|
||
| if (session != null) { | ||
| session.isStopped.set(true); | ||
| setChanged(); | ||
| notifyObservers(new NativeInterface.Message( |
There was a problem hiding this comment.
There should be an ObserverInterfaceTest covering STOP_SESSION events.
| @@ -326,6 +334,10 @@ private void handleStartSession(Object arg) { | |||
| warn("START_SESSION object is invalid: " + arg); | |||
| } | |||
|
|
|||
| private void handleStopSession() { | |||
There was a problem hiding this comment.
This method, while consistent with many of the others, is redundant. Could instead just call stoppedSession() above, similar to clearBreadcrumbs() and addHandledEvent(), which also don't need additional processing before crossing to the native layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds the ability to stop and resume sessions in the NDK layer. When a session is stopped, session information will not be added to error payloads and handled/unhandled error counts will not be incremented.
For fatal NDK errors, we cannot call the JNI without crashing the process, so we write an error report to disk using C. This PR updates the serialisation code to handle the concept of a stopped session.
See #429 for the Java implementation, and further details.
Changeset
SESSION_STARTEDobservable event fromSessionTracker.javawhen a session is started or resumed, which ultimately sets session information on the NDK payload.SESSION_STOPPEDobservable event, which sets a boolean flag onbugsnag_reportthat prevents serialisation of session information in fatal NDK error reportsSESSION_STARTEDevent to also include the handled count, rather than assuming it will always equal 0.Tests
Added mazerunner scenarios to verify that session information is not present in error payloads of a stopped session.