-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stopSession() and resumeSession() to public API #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazap10
reviewed
Mar 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine having a quick sanity check through it
fractalwrench
force-pushed
the
stop-sessions
branch
from
March 11, 2019 13:20
5202843
to
b0e6149
Compare
fractalwrench
changed the title
[WIP] Add stopSession() and resumeSession() to public API
Add stopSession() and resumeSession() to public API
Mar 11, 2019
kattrali
reviewed
Mar 11, 2019
kattrali
approved these changes
Mar 11, 2019
Add mazerunner scenarios for StopSession and ResumeSession
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds the ability to stop and resume sessions. This prevents the handled/unhandled error count from incrementing when a session is in the stopped state, which may be desirable if a user manually tracks sessions and does not care about crashes that occur in the background.
See previous PRs on Android and Cocoa for reference.
Changeset
StopSession
andResumeSession
toBugsnag.cs
Session.cs
to track whether a session is stopped or notSessionTracker.cs
so thatCurrentSession
returns null ifStopSession
is called, which prevents session information from being added to the session payload.check_package
task from RakefileTests
StartSession
,ResumeSession
, andStopSession
.Tests/BugsnagUnity.Tests
to allow for the construction of aSessionTracker
in NUnit tests.internal
and used[assembly: InternalsVisibleTo("class")]
to make classes visible to unit tests