Wait for session scenarios to send session before crashing #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cawllec
reviewed
Feb 26, 2019
| @@ -2,6 +2,8 @@ Feature: NDK Session Tracking | |||
|
|
|||
| Scenario: Stopped session is not in payload of unhandled NDK error | |||
| When I run "CXXStopSessionScenario" | |||
| And I wait a bit | |||
There was a problem hiding this comment.
What does this do, and why do we required two of them? Is it possible to detect if an app is running through CLI somehow?
There was a problem hiding this comment.
This step will wait for a set amount of time that is lower locally, but increased on CI. I believe it requires 2 as that's what was used in previous scenarios involving sessions and native errors.
I believe it might be possible to detect if an app is running through adb but we don't currently have that setup.
There was a problem hiding this comment.
Is it relied on somewhere else as well, or could we just bump the time up in a single step?
There was a problem hiding this comment.
I believe the timing is relied on in other places.
Cawllec
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E2E test job failed for Android 24 on CI only. I believe this is due to the native code killing the app before the session can be delivered, which is only an issue on Travis CI's slow ARM emulators.
The fix uses a handler to delay this crash for a reasonable period, meaning the session is always delivered in time. This mirrors the approach used in previous scenarios.