Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mazerunner scenarios for stopping/resuming a session #430

Merged
merged 5 commits into from
Feb 19, 2019

Conversation

fractalwrench
Copy link
Contributor

Goal

Verifies that no session information is present in an error payload when the session is stopped, and that the previous session information is used when the session is resumed.

This PR adds mazerunner test coverage. See #429 for the full implementation and explanation.

when a session is stopped, no session information should be present in error payloads.
And the request 1 is valid for the error reporting API
And the request 2 is valid for the error reporting API
And the payload field "events.0.session.events.handled" equals 1 for request 1
And the payload field "events.0.session.events.handled" equals 2 for request 2
Copy link
Contributor

@Cawllec Cawllec Feb 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to add a comparison between UUID's and start times here

@Cawllec
Copy link
Contributor

Cawllec commented Feb 19, 2019

What would happen if you paused sessions then called startSession?

Copy link
Contributor

@Cawllec Cawllec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merging into the stop-sessions branch

@fractalwrench fractalwrench merged commit 6181d68 into stop-sessions Feb 19, 2019
@fractalwrench fractalwrench deleted the stop-sessions-mazerunner-tests branch February 19, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants