Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update next from main #11066

Merged
merged 38 commits into from
Mar 10, 2023
Merged

Update next from main #11066

merged 38 commits into from
Mar 10, 2023

Conversation

jimblanc
Copy link
Contributor

@jimblanc jimblanc commented Mar 10, 2023

Description of changes

Updating next from main to pickup the latest changes. Will be merged as a merge commit.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

joesilveira and others added 30 commits February 16, 2023 17:10
Params should be of type PutObjectCommandInput
Clean Up-Unused Imports
…in IDB (#11019)

* indexeddb fix for queries against numeric indexes

* fix test model to not have required stringField
fixes typo for Cache prefix for personalize helper

Co-authored-by: AllanZhengYP <zheallan@amazon.com>
 - @aws-amplify/analytics@6.0.16
 - @aws-amplify/api-graphql@3.1.4
 - @aws-amplify/api-rest@3.0.16
 - @aws-amplify/api@5.0.16
 - @aws-amplify/auth@5.1.10
 - aws-amplify@5.0.16
 - @aws-amplify/cache@5.0.16
 - @aws-amplify/core@5.0.16
 - @aws-amplify/datastore-storage-adapter@2.0.16
 - @aws-amplify/datastore@4.0.16
 - @aws-amplify/geo@2.0.16
 - @aws-amplify/interactions@5.0.16
 - @aws-amplify/notifications@1.0.16
 - @aws-amplify/predictions@5.0.16
 - @aws-amplify/pubsub@5.0.16
 - @aws-amplify/pushnotification@5.0.16
 - @aws-amplify/storage@5.1.6
 - @aws-amplify/xr@4.0.16
Co-authored-by: AllanZhengYP <zheallan@amazon.com>
Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>
Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>
…or on models (#11009)

* starting with relevant changes from #10932

* add missing tabledef set to graphql fake

* fixed test expected field list

* test util for determining timestamp field names

* repro of issue

* timestamp fix

* chore: docstrings, re-enable all tests, remove integ testing from the branch

* remove cruft

* Update packages/datastore/src/datastore/datastore.ts

Co-authored-by: David McAfee <mcafd@amazon.com>

* updated for new nullish checks in tests from main

---------

Co-authored-by: David McAfee <mcafd@amazon.com>
Co-authored-by: Dane Pilcher <dppilche@amazon.com>
 - @aws-amplify/analytics@6.0.17
 - @aws-amplify/api-graphql@3.1.5
 - @aws-amplify/api-rest@3.0.17
 - @aws-amplify/api@5.0.17
 - @aws-amplify/auth@5.1.11
 - aws-amplify@5.0.17
 - @aws-amplify/cache@5.0.17
 - @aws-amplify/core@5.1.0
 - @aws-amplify/datastore-storage-adapter@2.0.17
 - @aws-amplify/datastore@4.0.17
 - @aws-amplify/geo@2.0.17
 - @aws-amplify/interactions@5.0.17
 - @aws-amplify/notifications@1.0.17
 - @aws-amplify/predictions@5.0.17
 - @aws-amplify/pubsub@5.1.0
 - @aws-amplify/pushnotification@5.0.17
 - @aws-amplify/storage@5.1.7
 - @aws-amplify/xr@4.0.17
…nused predicate function (#11040)

* added a few targeted TODO's from PR; in general, look for ops to cleanup as anys and bangs

* datastore.ts refactors and docstrings

* docstrings, small refactor, remove unused method
jimblanc and others added 8 commits March 7, 2023 17:40
 - @aws-amplify/analytics@6.0.18
 - @aws-amplify/api-graphql@3.1.6
 - @aws-amplify/api-rest@3.0.18
 - @aws-amplify/api@5.0.18
 - @aws-amplify/auth@5.1.12
 - aws-amplify@5.0.18
 - @aws-amplify/cache@5.0.18
 - @aws-amplify/core@5.1.1
 - @aws-amplify/datastore-storage-adapter@2.0.18
 - @aws-amplify/datastore@4.1.0
 - @aws-amplify/geo@2.0.18
 - @aws-amplify/interactions@5.0.18
 - @aws-amplify/notifications@1.0.18
 - @aws-amplify/predictions@5.0.18
 - @aws-amplify/pubsub@5.1.1
 - @aws-amplify/pushnotification@5.0.18
 - @aws-amplify/storage@5.1.8
 - @aws-amplify/xr@4.0.18
Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
fix(datastore): add fallback case for misc. bad input
* added a few targeted TODO's from PR; in general, look for ops to cleanup as anys and bangs

* datastore.ts refactors and docstrings

* docstrings, small refactor, remove unused method

* pruned a small chunk of unused storage predicate code away

* removed more redundant storage predicate code

* docstrings, remove unused storage createPredicate method

* undo changelog autoformats

* removed unused imports, function

* chore(@aws-amplify/datastore): fix small handful of 'as any' casts
@jimblanc jimblanc marked this pull request as ready for review March 10, 2023 00:26
@jimblanc jimblanc requested review from a team as code owners March 10, 2023 00:26
@codecov-commenter
Copy link

Codecov Report

Merging #11066 (448fc4c) into next (3f7a52f) will increase coverage by 0.30%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             next   #11066      +/-   ##
==========================================
+ Coverage   81.88%   82.19%   +0.30%     
==========================================
  Files         194      193       -1     
  Lines       19351    19456     +105     
  Branches     4173     4225      +52     
==========================================
+ Hits        15846    15992     +146     
+ Misses       3216     3177      -39     
+ Partials      289      287       -2     

see 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@haverchuck haverchuck self-requested a review March 10, 2023 22:36
@jimblanc jimblanc merged commit 9cfe377 into next Mar 10, 2023
@jimblanc jimblanc deleted the chore/update-next branch March 10, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.