chore(@aws-amplify/datastore): docstrings, small refactors, cleanup unused predicate function #11040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nup as anys and bangs
svidgen
commented
Mar 3, 2023
Comment on lines
-761
to
-765
| * TODO: the sortof-immutable algorithm was originally done to support legacy style | ||
| * predicate branching (`p => p.x.eq(value).y.eq(value)`). i'm not sure this is | ||
| * necessary or beneficial at this point, since we decided that each field condition | ||
| * must flly terminate a branch. is the strong mutation barrier between chain links | ||
| * still necessary or helpful? |
There was a problem hiding this comment.
Realistically, we'll never revisit this immutability. It has value if we ever need to extend predicates. And if we refactor here (which is possible), it'll be done holistically; not for the purpose of addressing this specific algorithmic choice.
svidgen
commented
Mar 3, 2023
| * | ||
| * @param modelDefinition The model that the AST/predicate must be compatible with. | ||
| * @param ast The graphQL style AST that should specify conditions for `modelDefinition`. | ||
| */ | ||
| static createFromAST( | ||
| modelDefinition: SchemaModel, | ||
| ast: any |
There was a problem hiding this comment.
A separate PR will attempt to address the any here.
svidgen
commented
Mar 3, 2023
| * | ||
| * @param gql GraphQL style filter node. | ||
| */ | ||
| static transformGraphQLFilterNodeToPredicateAST(gql: any) { |
There was a problem hiding this comment.
A separate PR will attempt to address the any here.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #11040 +/- ##
==========================================
- Coverage 85.65% 82.24% -3.42%
==========================================
Files 196 193 -3
Lines 18261 19367 +1106
Branches 3892 4185 +293
==========================================
+ Hits 15642 15928 +286
- Misses 2543 3151 +608
- Partials 76 288 +212
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
iartemiev
approved these changes
Mar 6, 2023
david-mcafee
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A batch of refactors, comments, etc., intended to improve readability.
Relationshipclass'sallFrommethod instead of duplicating that logic inline.Issue #, if available
Description of how you validated changes
No functional changes intended. Tests are expected to pass.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.